Repository navigation
Conversation
…eme's header and selected-tab tones The tab style drew a closed tab in button_normal_bg and the open one in panel_bg, so under a ui_theme scheme the open tab was darker than the others, the reverse of Textual's tab bar. Tabs now read two declared roles, tab_bg and selected_tab_bg. The presets keep today's values, so OpenHCS's tabs do not change. `from_theme` maps them to ui_theme's HeaderToneColour and its new SelectedTabToneColour (a tier off the bar). Test: every drawable scheme's touching chrome surfaces are at least TIER_GAP lightness apart, and secondary text reads on every area surface. Needs ui-theme's tone tiers (OpenHCSDev/ui-theme, claude-a/tone-tiers) merged first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Under a ui_theme scheme, Qt's tab style drew a closed tab in
button_normal_bg(ui_theme's surface hover) and the open one inpanel_bg(the sidebar tone). So the open tab was darker than the closed ones in every scheme (ΔL* −4 to −10). That is the reverse of Textual's tab bar, where tabs sit on the header tone.What changed
ColorScheme.tab_bgandselected_tab_bg.generate_tab_color_stylereads them.#404040/#1e1e1e, light#e6e6e6/#ffffff), so OpenHCS's tabs look the same.from_theme: mapstab_bgto ui_theme'sHeaderToneColourandselected_tab_bgto its newSelectedTabToneColour, which sits aTIER_GAPoff the bar.Tests
test_chrome_takes_the_theme_coloursalso states the two tab roles.New
test_touching_chrome_surfaces_are_a_tier_apart_and_text_reads_on_each: for every drawable scheme, these chrome pairs must be at least ui_theme'sTIER_GAPL* apart:It also checks that
text_secondaryreads at ≥ 4.5:1 (as far astext_primarydoes) on every area surface.Results:
test_color_scheme_from_theme.py38 passed. The other 20 test files that touchColorSchemeor the style generator have 28 failing tests, the identical set on main (dock layout, widget projection, frame callbacks), so none are new.Per-scheme before/after numbers are in OpenHCSDev/ui-theme#33.
Rollout
Needs OpenHCSDev/ui-theme#33 merged first, for
SelectedTabToneColourandTIER_GAP. Then rebuild the agent-comms runtime, then merge the toad PR.🤖 Generated with Claude Code
https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3