Repository navigation
Reuse sidebar thread rows across count-only bus updates - #4884
Merged
Merged
Conversation
P260: derive roster invalidation from RosterView, retaining the original acquired ThreadViews separately from the bus count cut. Count-only updates no longer reread every goal. Applied authored NRA patch_target/ensure_import plans after simulation and parse validation; semantic source-selection decision checked through the real-store consumer. 56 focused checks passed. Warm alternated 24-goal roster/assembly phase:11.88ms fresh,1.46ms acquired; no total CPU claim.
trissim
marked this pull request as ready for review
November 18, 2026 06:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result
Owner repair
ThreadView.rosterstill derives the thread rows.CoordinationSnapshot.capturenow assembles caller-acquired rows with the current bus cut.SidebarReadStageretains those rows beside the exact revision that supplied them; it only reacquires whenRosterViewchanges.RosterViewinheritsActivityView, so registration, ownership/activity, runtime information, room and expiry dependencies remain declaration-derived. Goal execution feeds the new view directly.SidebarViewinherits both the roster and count-cut views. No new source-path list, timer, process or launch authority.The direct fresh snapshot reader and initial lightweight roster reader still acquire fresh rows. Unread/count/channel clocks keep their existing owners. User windows and all uncertain inputs remain untouched.
Evidence and limits
NRA authored
patch_target/ensure_importplan simulated, reviewed and applied with parse checks. Source-selection semantics were chosen from the actual owners, not proved by an empty NRA guard suite. Plans and outputs retained in/home/ts/.cache/agent-scratch/codex-latency/sidebar-roster/.Before control failed7!=1. First after run exposed initialization of absent derived-store source files; control now settles those real revisions before counting new acquisitions. Two fixture errors (expecting native idle activity to show a synthetic working detail, then deleting a heartbeat thread without stopping it) were corrected through their real owners; failed outputs retained. Final coherent affected run:56 passed,exit0.
Assumed: the existing declared activity/goal wake and expiry sources remain the roster freshness contract. No additional timeout or stale-data allowance is introduced. Existing open Toad windows retain their loaded code until reopened. No physical UI or overall CPU resolution claimed.