Repository navigation
Batch activity cohort reads through the keyed table owner - #4885
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
November 18, 2026 07:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
12 focused checks pass; 67 activity queries become one requested-key query. Equal-warm alternated real-store captures: median 4.173 ms before / 3.304 ms after. This modest saving covers activity reads only, not total observer or UI CPU.
Repair
ActivityStore.captured_for uses ActivityRow.stream_keys, the existing indexed requested-key reader, instead of issuing ActivityRow.stream once per thread. TypedTable owns connection-variable batching. Original row decoding, requested-name order, missing activity, active stale activity and expiry retain their existing owners. No new cache, schema, carry or timer.
The control emits real events through ActivityStore, traces its original snapshot, and checks duplicate/missing names, expiry and query count. The exact historical owner method supplies the benchmark baseline.
Applied through an authored declaration-selected NRA plan; independent real-store checks supply semantic evidence. Existing guarded imports are outside this narrow hot-path repair; no whole-module slop cleanup is claimed.
Artifacts: /home/ts/.cache/agent-scratch/codex-latency/batched-activity/
Fixes P263.