Repository navigation
Distinguish changed requirements from recurring defects - #4887
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
November 18, 2026 08:28
|
debt-tools at d76d3f6 failed without a verdict line; the last lines of its stderr: |
|
debt-src at d76d3f6 failed without a verdict line; the last lines of its stderr: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P269: changed requirements are not repeated defects
35 targeted checks passed, exit 0. The P255/P266 regression uses the same
paper/manuscript.mdIntroduction declaration: an ordinary repeatedfixstill fails without factoring evidence, while an explicitly explained requirement change passes. No paper source, build or delivery was changed.One edit family, two reasons for editing
RequirementChangeScopeinheritsFixScope. It keeps the same source references, shape, checked delivery, completion claims and PR instructions. Its requiredchangevalue explains the owner's changed requirement; missing and empty explanations fail decoding. It declares no repeated defect to the recurrence check. OrdinaryFixScopekeeps its original declaration-based recurrence rule.FixScope.instructionsreads the scope's declared name instead of repeatingfix, so the new member renders itself without another roster or consumer switch. A scope that declares no recurrence no longer scans old problems for one.Supported order input
Keep the existing owner and shape locations. For the new paper requirement, use:
This is a source-edit scope, not triage. The existing
agent-comms-team order problempath remains the entry point. No fake duplicated fact, moved manuscript location, alternate API or paper-order replay is introduced. Paper work remains with openhcs-paper.Evidence
The run covers the new same-manuscript regression and explanation boundary, all scope file/native delivery checks, Markdown declaration identity, ordinary repeated-fix factoring checks, triage behavior and withdrawn-order recurrence behavior. The scope recall assertion now reads the existing scope label owner rather than pinning obsolete lowercase copies.
Initial run: 28 passed / 2 failed. One new fixture omitted registering its assignee; it now uses the real registry. An existing recall assertion pinned lowercase labels while the existing label owner supplies title case; its owner-derived assertion retains holder/problem/scope/edit checks. Those failed outputs are retained, not counted as green.
Evidence is under
/home/ts/.cache/agent-scratch/comms-commander-2/recurrence-requirement/, includingtests.log,tests-2.logandtests-2.exit. The real installed writer retry is the final application check and will be reported separately.The distinction follows paper1 Corollary 4.19: changing required behavior changes the specification; it is not evidence that the previous requirement broke again.