Skip to content

Distinguish changed requirements from recurring defects - #4887

Merged
trissim merged 1 commit into
mainfrom
fix/requirement-change-recurrence
Nov 18, 2026
Merged

trissim merged 1 commit into
mainfrom
fix/requirement-change-recurrence

Conversation

@trissim

@trissim trissim commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

P269: changed requirements are not repeated defects

35 targeted checks passed, exit 0. The P255/P266 regression uses the same paper/manuscript.md Introduction declaration: an ordinary repeated fix still fails without factoring evidence, while an explicitly explained requirement change passes. No paper source, build or delivery was changed.

One edit family, two reasons for editing

RequirementChangeScope inherits FixScope. It keeps the same source references, shape, checked delivery, completion claims and PR instructions. Its required change value explains the owner's changed requirement; missing and empty explanations fail decoding. It declares no repeated defect to the recurrence check. Ordinary FixScope keeps its original declaration-based recurrence rule.

FixScope.instructions reads the scope's declared name instead of repeating fix, so the new member renders itself without another roster or consumer switch. A scope that declares no recurrence no longer scans old problems for one.

Supported order input

Keep the existing owner and shape locations. For the new paper requirement, use:

"scope": {
  "kind": "requirement_change",
  "shape": {"parents": ["openhcsdev/openhcs:paper/build_paper.py:30"], "members": []},
  "change": "P255 applied the earlier 45 edits; Tristan now requests Alyson's exact V2 Introduction and selected old-introduction examples in Discussion."
}

This is a source-edit scope, not triage. The existing agent-comms-team order problem path remains the entry point. No fake duplicated fact, moved manuscript location, alternate API or paper-order replay is introduced. Paper work remains with openhcs-paper.

Evidence

The run covers the new same-manuscript regression and explanation boundary, all scope file/native delivery checks, Markdown declaration identity, ordinary repeated-fix factoring checks, triage behavior and withdrawn-order recurrence behavior. The scope recall assertion now reads the existing scope label owner rather than pinning obsolete lowercase copies.

Initial run: 28 passed / 2 failed. One new fixture omitted registering its assignee; it now uses the real registry. An existing recall assertion pinned lowercase labels while the existing label owner supplies title case; its owner-derived assertion retains holder/problem/scope/edit checks. Those failed outputs are retained, not counted as green.

Evidence is under /home/ts/.cache/agent-scratch/comms-commander-2/recurrence-requirement/, including tests.log, tests-2.log and tests-2.exit. The real installed writer retry is the final application check and will be reported separately.

The distinction follows paper1 Corollary 4.19: changing required behavior changes the specification; it is not evidence that the previous requirement broke again.

@trissim
trissim marked this pull request as ready for review November 18, 2026 08:28
@trissim
trissim merged commit d9444e8 into main Nov 18, 2026
7 of 9 checks passed
@github-actions

Copy link
Copy Markdown

debt-tools at d76d3f6 failed without a verdict line; the last lines of its stderr:

concurrent.futures.process._RemoteTraceback:
"""
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.14.10/x64/lib/python3.14/concurrent/futures/process.py", line 255, in _process_worker
    r = call_item.fn(*call_item.args, **call_item.kwargs)
  File "/home/runner/work/agent-comms/agent-comms/src/agent_comms/execution/child_process.py", line 2735, in _work
    return work()
  File "/home/runner/work/agent-comms/agent-comms/tools/agent_comms_project.py", line 300, in findings
    output = cls.checker_output(result, f"{client.name} at {ref}")
  File "/home/runner/work/_temp/checker-venv/lib/python3.14/site-packages/nominal_refactor_advisor/audit/gate.py", line 165, in checker_output
    raise ValueError(f"{cls.__name__} could not check {subject}: {output}")
ValueError: ClientTypeErrors could not check batrachian-toad at 4d0206b14930fa4e1b29ed6385d275e157c794d8: tools/qt_drive.py: error: Source file found twice under different module names: "tools.qt_drive" and "qt_drive"
tools/qt_drive.py: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-file-paths-to-modules for more info
tools/qt_drive.py: note: Common resolutions include:
tools/qt_drive.py: note:     a) adding `__init__.py` somewhere,
tools/qt_drive.py: note:     b) using `--explicit-package-bases` or adjusting `MYPYPATH`
"""
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
  File "/home/runner/work/agent-comms/agent-comms/tools/nra_gate.py", line 15, in <module>
    raise SystemExit(audit.gate.main(project, arguments))
                     ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/_temp/checker-venv/lib/python3.14/site-packages/nominal_refactor_advisor/audit/gate.py", line 1161, in main
    return gate(project, args.base, args.head, args.root, args.workers)
  File "/home/runner/work/_temp/checker-venv/lib/python3.14/site-packages/nominal_refactor_advisor/audit/gate.py", line 1134, in gate
    result = compare(repo, base, head, root, workers, Compared.members())
  File "/home/runner/work/_temp/checker-venv/lib/python3.14/site-packages/nominal_refactor_advisor/audit/gate.py", line 1101, in compare
    results[measure] = [part.result() for part in parts[measure]]
                        ~~~~~~~~~~~^^
  File "/opt/hostedtoolcache/Python/3.14.10/x64/lib/python3.14/concurrent/futures/_base.py", line 447, in result
    return self.__get_result()
           ~~~~~~~~~~~~~~~~~^^
  File "/opt/hostedtoolcache/Python/3.14.10/x64/lib/python3.14/concurrent/futures/_base.py", line 396, in __get_result
    raise self._exception
ValueError: ClientTypeErrors could not check batrachian-toad at 4d0206b14930fa4e1b29ed6385d275e157c794d8: tools/qt_drive.py: error: Source file found twice under different module names: "tools.qt_drive" and "qt_drive"
tools/qt_drive.py: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-file-paths-to-modules for more info
tools/qt_drive.py: note: Common resolutions include:
tools/qt_drive.py: note:     a) adding `__init__.py` somewhere,
tools/qt_drive.py: note:     b) using `--explicit-package-bases` or adjusting `MYPYPATH`

@github-actions

Copy link
Copy Markdown

debt-src at d76d3f6 failed without a verdict line; the last lines of its stderr:

concurrent.futures.process._RemoteTraceback:
"""
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.14.10/x64/lib/python3.14/concurrent/futures/process.py", line 255, in _process_worker
    r = call_item.fn(*call_item.args, **call_item.kwargs)
  File "/home/runner/work/agent-comms/agent-comms/src/agent_comms/execution/child_process.py", line 2735, in _work
    return work()
  File "/home/runner/work/agent-comms/agent-comms/tools/agent_comms_project.py", line 300, in findings
    output = cls.checker_output(result, f"{client.name} at {ref}")
  File "/home/runner/work/_temp/checker-venv/lib/python3.14/site-packages/nominal_refactor_advisor/audit/gate.py", line 165, in checker_output
    raise ValueError(f"{cls.__name__} could not check {subject}: {output}")
ValueError: ClientTypeErrors could not check batrachian-toad at 4d0206b14930fa4e1b29ed6385d275e157c794d8: tools/qt_drive.py: error: Source file found twice under different module names: "tools.qt_drive" and "qt_drive"
tools/qt_drive.py: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-file-paths-to-modules for more info
tools/qt_drive.py: note: Common resolutions include:
tools/qt_drive.py: note:     a) adding `__init__.py` somewhere,
tools/qt_drive.py: note:     b) using `--explicit-package-bases` or adjusting `MYPYPATH`
"""
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
  File "/home/runner/work/agent-comms/agent-comms/tools/nra_gate.py", line 15, in <module>
    raise SystemExit(audit.gate.main(project, arguments))
                     ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/_temp/checker-venv/lib/python3.14/site-packages/nominal_refactor_advisor/audit/gate.py", line 1161, in main
    return gate(project, args.base, args.head, args.root, args.workers)
  File "/home/runner/work/_temp/checker-venv/lib/python3.14/site-packages/nominal_refactor_advisor/audit/gate.py", line 1134, in gate
    result = compare(repo, base, head, root, workers, Compared.members())
  File "/home/runner/work/_temp/checker-venv/lib/python3.14/site-packages/nominal_refactor_advisor/audit/gate.py", line 1101, in compare
    results[measure] = [part.result() for part in parts[measure]]
                        ~~~~~~~~~~~^^
  File "/opt/hostedtoolcache/Python/3.14.10/x64/lib/python3.14/concurrent/futures/_base.py", line 447, in result
    return self.__get_result()
           ~~~~~~~~~~~~~~~~~^^
  File "/opt/hostedtoolcache/Python/3.14.10/x64/lib/python3.14/concurrent/futures/_base.py", line 396, in __get_result
    raise self._exception
ValueError: ClientTypeErrors could not check batrachian-toad at 4d0206b14930fa4e1b29ed6385d275e157c794d8: tools/qt_drive.py: error: Source file found twice under different module names: "tools.qt_drive" and "qt_drive"
tools/qt_drive.py: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-file-paths-to-modules for more info
tools/qt_drive.py: note: Common resolutions include:
tools/qt_drive.py: note:     a) adding `__init__.py` somewhere,
tools/qt_drive.py: note:     b) using `--explicit-package-bases` or adjusting `MYPYPATH`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant