Repository navigation
Qt sidebar widgets: force Qt.Widget flag to survive transient parent=None - #36
Merged
Merged
Conversation
Passing parent= alone wasn't enough on Qt-for-Android: src/toad/qt/window.py's _layout_panes calls bar.setParent(None) during rearrangement, and in the window between that call and the next setParent(dock) Qt treats the widget as a top-level QWindow and gives it its own EGL surface — same crash as a true orphan. Second SidebarToggleClassWindow still races QtAndroidAccessibility::runInObjectContext() one second after ApplicationActive. setWindowFlags(Qt.WindowType.Widget) tells Qt explicitly: this is a child widget, never a window, even when parent is None. Qt then refuses to allocate a top-level window for the transient parent-less state. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on PR #35.
parent=alone isn't enough on Qt-for-Android: toad's_layout_panesdoesbar.setParent(None)mid-rearrangement, and in that window Qt gives the widget a top-level QWindow + EGL surface → SIGABRT when the second EGL surface races accessibility.setWindowFlags(Qt.WindowType.Widget)tells Qt explicitly: child widget, never a window, even when parent is transiently None. Applied to all three Qt sidebar widgets.Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn