Repository navigation
Qt sidebar pane: controls in a horizontal row at the bottom - #38
Merged
Merged
Conversation
The pane previously branched on edge axis: horizontal pane (top/bottom edge) got a row of controls, vertical pane (left/right edge) got a column stacked on the interior side. On a narrow phone screen the column consumes disproportionate space and the pane's content barely fits. A row at the bottom is uniformly compact across all edges. Deletes _is_horizontal_axis and _controls_leading — no caller references either outside the pane. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SidebarPane._apply_layout_forpreviously branched on the edge axis: top/bottom edges got a row of controls at the far edge, left/right edges got a column stacked on the interior side. On a narrow phone pane the vertical column eats disproportionate screen real estate.A row at the bottom is uniformly compact across every edge. Deletes
_is_horizontal_axisand_controls_leading— no caller outside the pane referenced either.Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn