Skip to content

sidebar widgets: setObjectName for host QSS targeting - #39

Merged
trissim merged 1 commit into
mainfrom
fix/sidebar-objectnames
Nov 17, 2026
Merged

trissim merged 1 commit into
mainfrom
fix/sidebar-objectnames

Conversation

@trissim

@trissim trissim commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

SidebarPane and SidebarToggle had no object-name, so host QSS could only target QWidget (which bled into every descendant QWidget). Set each to its class name so the host's selector keys on #SidebarPane / #SidebarToggle and paints only the intended widget.

Matches pyqt-reactive's new generate_sidebar_pane_style() / generate_sidebar_bar_style() selectors (OpenHCSDev/PyQT-reactive#62).

🤖 Generated with Claude Code

https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn

`SidebarPane` and `SidebarToggle` previously had no object-name, so the host's
QSS could only paint them by targeting `QWidget`, which bled into every
descendant QWidget of their ancestors. Set each to its class name so the host
can key a selector on `#SidebarPane` / `#SidebarToggle` and paint only the
intended widget.

Matches pyqt-reactive's new `generate_sidebar_pane_style()` /
`generate_sidebar_bar_style()` selectors.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn
@trissim
trissim merged commit 408a00f into main Nov 17, 2026
trissim added a commit to OpenHCSDev/toad that referenced this pull request Nov 17, 2026
Qt sidebar panes and toggle bars applied no background stylesheet and inherited
the parent QWidget's default colour, so the themed sidebar tone never reached
the sidebar. Pull from pyqt-reactive's new `generate_sidebar_pane_style()` /
`generate_sidebar_bar_style()` (keyed on `#SidebarPane` / `#SidebarToggle`
object-names set by formbridge) and apply each after construction, mirroring
the pattern already used for float layer, tab widget and bottom chrome.

Pane paints `panel_bg` (SidebarToneColour — Textual's `SideBar.tone`).
Bar paints `frame_bg` (HeaderToneColour — Textual's toggle-bar CSS at
`widgets/side_bar.py:322` tinting PrimaryColour at 8%).

Pairs with:
- pyqt-reactive OpenHCSDev/PyQT-reactive#62
- formbridge OpenHCSDev/formbridge#39

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn
trissim added a commit to OpenHCSDev/toad that referenced this pull request Nov 17, 2026
Qt sidebar panes and toggle bars applied no background stylesheet and inherited
the parent QWidget's default colour, so the themed sidebar tone never reached
the sidebar. Pull from pyqt-reactive's new `generate_sidebar_pane_style()` /
`generate_sidebar_bar_style()` (keyed on `#SidebarPane` / `#SidebarToggle`
object-names set by formbridge) and apply each after construction, mirroring
the pattern already used for float layer, tab widget and bottom chrome.

Pane paints `panel_bg` (SidebarToneColour — Textual's `SideBar.tone`).
Bar paints `frame_bg` (HeaderToneColour — Textual's toggle-bar CSS at
`widgets/side_bar.py:322` tinting PrimaryColour at 8%).

Pairs with:
- pyqt-reactive OpenHCSDev/PyQT-reactive#62
- formbridge OpenHCSDev/formbridge#39


Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant