Repository navigation
The last MRO walks go through OwnDeclarations; NativeTextKeys comes from formbridge - #324
Merged
Merged
Conversation
…rom formbridge DeclaresTheme inherits OwnDeclarations: declared_theme, theme_states and declared_components read declared_items, declared_of and own_declarations instead of three vars(owner) walks. NativeTextKeys leaves _editing.py for formbridge; DOMNode's key_mode is typed by the text-entry identity, so dom.py no longer imports the TextArea engine. Screen's default stays the EditingMode engine: Toad builds it as a TextArea engine (prompt.py:511). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows OpenHCSDev/metaclass-registry#18 and OpenHCSDev/formbridge#30.
native_theme), dom.py:1142 (ThemeState descriptors) and dom.py:1171 (native_components) were the last hand-writtenvars(owner)walks over the MRO. DeclaresTheme inherits OwnDeclarations; the three readdeclared_items,declared_ofandown_declarations. The reactive walk at dom.py:1018 is upstream's.type[TextEntryMode], so dom.py drops its EditingMode import. Screen.key_mode keeps returning the EditingMode engine because Toad instantiates it as a TextArea engine (toad prompt.py:511).Checks: theme/component dump over every DOM class (1,415 lines) identical; bindings dump identical; css, input, widget, navigation_spellings and text_area binding tests 618 passed.
🤖 Generated with Claude Code
https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn