Skip to content

Qt sidebar: expose the search input via QtSidebarSearch - #1975

Merged
trissim merged 1 commit into
mainfrom
qt/sidebar-search-input
Nov 17, 2026
Merged

trissim merged 1 commit into
mainfrom
qt/sidebar-search-input

Conversation

@trissim

@trissim trissim commented Nov 17, 2026

Copy link
Copy Markdown

Sidebar.filter + _on_filter_changed and draw_lines filtering were co-landed via PR #1974, but the QLineEdit that writes the shared owner's text was still missing — so the match machinery had no way to receive a user keystroke.

QtSidebarSearch stacks a QLineEdit over the Sidebar tree. The sidebar pane takes the wrapper as its content so the input is visible at the top of the pane, mirroring Textual's SideBar._compose_shell which stacks SidebarSearch over its panels for the same reason. The input writes directly through sidebar.filter.text; the tree's existing subscriber re-presents so every channel/thread row re-asks SidebarFilter.matches(name) on each keystroke.

🤖 Generated with Claude Code

https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn

`Sidebar.filter` + `_on_filter_changed` and `draw_lines` filtering already
landed through PR #1974's co-paint of nearby chunks, but the `QLineEdit` that
writes the shared owner's text was still missing, so the match machinery had
no way to receive a user keystroke.

`QtSidebarSearch` stacks a `QLineEdit` over the `Sidebar` tree. The sidebar
pane takes the wrapper as its content so the input is visible at the top of
the pane, mirroring Textual's `SideBar._compose_shell` which stacks
`SidebarSearch` over its panels for the same reason. The input writes directly
through `sidebar.filter.text`; the tree's existing subscriber re-presents so
every channel/thread row re-asks `SidebarFilter.matches(name)` on each keystroke.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn
@trissim
trissim merged commit 0610285 into main Nov 17, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant