Repository navigation
qt feedback: waits through one pending owner, notices float over the page, menu rows follow the input modality - #2098
Merged
Merged
Conversation
…r the page, menu rows follow the input modality Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3
…ontent The QFrame menu row (its own area the tap target, wrapping labels in nested layouts) left qasync's loop running no callbacks after the window closed, once the panel had opened over a thread tab and #comms: the feedback drive never reached the end of close_client. The button row closes cleanly. Under touch it shows no key column, an elided description line, and a 48dp minimum height. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3
trissim
force-pushed
the
fork-qt-feedback-overlays
branch
from
November 18, 2026 06:44
93dbf40 to
fc3f600
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tristan, on the phone: more loading animations so a delay doesn't look like a locked UI; errors push the page down instead of floating; the menu shows shortcuts and looks bad on mobile.
Loading: one pending owner
toad.client.pendingdeclares each wait once, as aPendingWorkmember with the words the reader sees:ThreadOpening: "Loading thread and history…"HistoryPage: "Loading messages…"ChoicesPreparation: "Loading choices…"BusConnecting,ActionRunning,ApplyingShowsPending.while_pendingis the one algorithm: show the work afterpending_delay(0.15 s, so a fast load never flashes), and clear it however the wait ends.@awaited(...):MenuActionRun,ThreadActionRun,CommandFieldsPreparation,CommandApply,BusSwitch,GoalPress,DirectMessagesOpen,ChannelsReveal,NewThreadForm. Qt'srun_operationshows the work for any of them in the float layer, so there is no spinner at any call site. Background kinds map toNoPendingWorkand show nothing.QtOpeningSessionViewshowsThreadOpeningwith Toad's activity sweep in place, after the delay. Before, it was a static "Opening X…" label.AwaitsFirstPageholds the TUI's rule: the wait goes oncerows_publishedfinds something drawn. Textual'sWireHistorynow inherits it, which deletes its ownrows_publishedoverride. Qt's newQtWireHistory, used by the channel and DM view, inherits it and floatsHistoryPageover the window.ChoicesPreparationwhile its catalog refreshes.ThreadLoading.LABEL,HistoryLoading's text, andCommandDraft's "Loading choices…".Errors float
Qt's notices used to go to a
StatusLineplaced inside the navigation band, so each one pushed the pages down.QtFloatLayeris a child of the window, never a top-level window, and is outside every layout. It stacks up to 3QtNoticeCards in severity colours. Each card leaves after the host'snotice_seconds, or sooner on a tap, as a Textual toast does.QtCommsHost.notifyposts there.status_line.show_statuswrites (mailbox open failure, composer mount failure) now go throughshow_error, so they are saved like every other error.follow_scheme).Menu rows follow the input modality
toad.client.input_modalitydeclaresKeyboardInput(rows show keys; description inline) andTouchInput(no key column, 48 dp tap height, description on its own line).BlockMenu.input_modality(default keyboard) decidesrow_keysandrow_textfor both frontends; Textual'sMenuOptionasks it too. Qt's menu takesTouchInputon Android (QGuiApplication.platformName() == "android").QtMenuRowstays the button row (labels over aQPushButton). Under touch it shows no key column, puts the description on its own elided line, and sets a minimum height of 48 dp, or two lines if taller.NewSessionAction's docstring carried a developer note into every menu and palette. It is now one line, with the note moved to a comment.Drive at 412 px: under touch, 12 rows with no keys shown and the shortest row 48 px. At 790 px under keys:
ctrl+s,ctrl+shift+d,ctrl+qshown.Evidence (head rebased on 1aae804)
QtNoticeCard, with its reason.shadow_check0.tools/android/check.shexit 0: 21 ofKNOWN_LAZY's 21 entries, none new.qt_drive.py feedbackscenario (offscreen, live bus, stray-window check on):menu,surround(scratch thread) andhistory(#comms) all exit 0.menuandcommandnow read notices from the float layer instead of the status line.test_archive_from_thread_menu, also fails on main.Closing after the menu: found and fixed (second commit)
The
feedbackdrive used to hang at exit. A first version of this PR made each menu row aQFramewhose own area was the tap target, with wrapping labels in nested layouts. Once the menu panel had been opened over a thread tab and #comms, closing the window left qasync's loop running no callbacks: a watchdog task due 15 s afterapp.close()never ran,close_client()never returned, and the render pool's live executor thread then kept the process alive.Isolated in runs, each the drive with one piece changed:
WrappedTextlabelsCLOSED, rc 0)The render pool was created once, before close, and received nothing after it. The row structure is the trigger. Which part of the frame row re-entered Qt's layout or event processing is not established; the shipped row is the button row, which closes cleanly. With it, both this drive and
feedbackexit 0. Main'stabsscenario also exits 0, so main does not carry this.Known
🤖 Generated with Claude Code
https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3