Skip to content

Exit cleanly when startup fails instead of leaving a zombie JVM (fixes #498, fixes #499) #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iacsha wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Exit cleanly when startup fails instead of leaving a zombie JVM (fixes #498, fixes #499) #565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions server/src/main/java/com/mirth/connect/server/Mirth.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ public class Mirth extends Thread {

private Logger logger = LogManager.getLogger(this.getClass());
private boolean running = false;
private volatile boolean startupComplete = false;

/** Process exit code when the server aborts during startup (see #498, #499). */
private static final int EXIT_STARTUP_FAILURE = 1;
private PropertiesConfiguration mirthProperties = PropertiesConfigurationUtil.create();
private PropertiesConfiguration versionProperties = PropertiesConfigurationUtil.create();
private MirthWebServer webServer;
Expand Down Expand Up @@ -150,7 +154,10 @@ public void run() {
boolean httpsPort = testPort(mirthProperties.getString("https.host"), mirthProperties.getString("https.port"), "https.port");

if (!httpPort || !httpsPort) {
return;
// Startup failed before anything started. MirthLauncher runs this class as a
// thread and never calls main(), so returning would leave the JVM alive with no
// listeners; exit so a service manager sees the failure. See #498.
System.exit(EXIT_STARTUP_FAILURE);
}

running = true;
Expand Down Expand Up @@ -322,7 +329,10 @@ public void startup() {
logger.error("Failed to migrate database schema", e);
stopDatabase();
running = false;
return;
// Exit instead of leaving a zombie JVM (see #498). The shutdown hook is already
// registered but is guarded by startupComplete, so it will not run the full
// shutdown, which would hang reading the now-stopped Derby database. See #499.
System.exit(EXIT_STARTUP_FAILURE);
}

// MIRTH-3535 disable Quartz update check
Expand Down Expand Up @@ -399,6 +409,7 @@ public void startup() {
configurationController.setStatus(ConfigurationController.STATUS_OK);
eventController.dispatchEvent(new ServerEvent(configurationController.getServerId(), "Server startup complete"));
printSplashScreen();
startupComplete = true;

// schedule usage statistics to be sent at startup and every 24 hours
if (BrandingConstants.SEND_USAGE_STATISTICS) {
Expand Down Expand Up @@ -528,7 +539,11 @@ private void stopDatabase() {
private class ShutdownHook extends Thread {
public void run() {
Thread.currentThread().setName("Shutdown Hook Thread");
shutdown();
// Only run the full shutdown if the server finished starting. After a failed startup
// the engine and database are not up, and shutdown() would hang reading Derby. See #499.
if (startupComplete) {
shutdown();
}

for (Thread thread : shutdownHooks) {
thread.start();
Expand Down