Skip to content

Select the diffSimulationResults tube - #422

Merged
sjoelund merged 1 commit into
masterfrom
diff-algorithm
Nov 16, 2026
Merged

sjoelund merged 1 commit into
masterfrom
diff-algorithm

Conversation

@sjoelund

Copy link
Copy Markdown
Member

OpenModelica/OpenModelica#14590 asks whether the CI must compare like csv-compare, whose rectangle tube is what MSL and MAP-Lib use. To measure what that changes, a pull request run must be able to verify with another tube.

  • testmodel.py: when the configuration has a reference_tube, pass tube=OpenModelica.Scripting.TubeAlgorithm.<reference_tube> to diffSimulationResults. Without it the call is the same as before, so the nightly omc still works.
  • test.py: --reference_tube sets reference_tube for every library, and the report names the tube. A run with it has another confighash.
  • .CI/Jenkinsfile: pull_request_tube sets --reference_tube. pull_request_verifier=pull request runs OMPython with the omc built from the pull request instead of /usr, because the nightly of the testing image does not know the tube argument yet. Other runs keep /usr.
  • README.md: document reference_tube.

Needs the OpenModelica pull request that adds the tube argument.

Assisted-by: Claude Opus 5.5

OpenModelica #14590 asks whether the CI must compare like csv-compare,
whose rectangle tube is what MSL and MAP-Lib use. To measure what that
changes, a pull request run must be able to verify with another tube.

- testmodel.py: when the configuration has a reference_tube, pass
  tube=OpenModelica.Scripting.TubeAlgorithm.<reference_tube> to
  diffSimulationResults. Without it the call is the same as before,
  so the nightly omc still works.
- test.py: --reference_tube sets reference_tube for every library, and
  the report names the tube. A run with it has another confighash.
- .CI/Jenkinsfile: pull_request_tube sets --reference_tube.
  pull_request_verifier=pull request runs OMPython with the omc built
  from the pull request instead of /usr, because the nightly of the
  testing image does not know the tube argument yet. Other runs keep
  /usr.
- README.md: document reference_tube.

Needs the OpenModelica pull request that adds the tube argument.

Assisted-by: Claude Opus 5.5
@sjoelund
sjoelund merged commit 79b27d4 into master Nov 16, 2026
7 checks passed
@sjoelund
sjoelund deleted the diff-algorithm branch November 16, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant