Skip to content

Mark models with non-standard Modelica as invalid - #427

Merged
sjoelund merged 2 commits into
masterfrom
nonstandard-modelica
Nov 17, 2026
Merged

sjoelund merged 2 commits into
masterfrom
nonstandard-modelica

Conversation

@sjoelund

Copy link
Copy Markdown
Member

Some libraries were tested with --allowNonStandardModelica and others were not. Thus the overviews counted some non-standard models as working, and did not show how far the others would get.

Testing:

  • test.py adds --warnNonStandardModelica to the default commands if omc accepts it, and the configurations no longer set --allowNonStandardModelica.
  • testmodel.py finds the "[Non-standard Modelica: ...]" tag in the messages of omc and writes the options to .stat.json.
  • Each branch table gets the column invalid (sqlite user_version 6).

Library reports put a red cross before the name of an invalid model and give the number of invalid models.

Overviews:

  • The newest run of master on each library says which models are invalid; --invalid-branch selects another branch, for the libraries that master does not test.
  • The counts and times leave out the invalid models. Buttons at the top show them included, or only them.
  • The "Now working in ..." tooltips are removed, and one query reads the rows of a library and branch.
  • New style sheet.

Merge this only after a nightly omc has --warnNonStandardModelica.

Fixes #426.

Assisted-by: Claude Opus 5.5

Some libraries were tested with --allowNonStandardModelica and others
were not. Thus the overviews counted some non-standard models as
working, and did not show how far the others would get.

Testing:
- test.py adds --warnNonStandardModelica to the default commands if
  omc accepts it, and the configurations no longer set
  --allowNonStandardModelica.
- testmodel.py finds the "[Non-standard Modelica: ...]" tag in the
  messages of omc and writes the options to .stat.json.
- Each branch table gets the column invalid (sqlite user_version 6).

Library reports put a red cross before the name of an invalid model
and give the number of invalid models.

Overviews:
- The newest run of master on each library says which models are
  invalid; --invalid-branch selects another branch, for the libraries
  that master does not test.
- The counts and times leave out the invalid models. Buttons at the
  top show them included, or only them.
- The "Now working in ..." tooltips are removed, and one query reads
  the rows of a library and branch.
- New style sheet.

Merge this only after a nightly omc has --warnNonStandardModelica.

Fixes #426.

Assisted-by: Claude Opus 5.5
The overview no longer puts each count in <a>, and </table> is now on
the next line. Thus the grep in the workflow did not find the row, and
all four jobs failed, although both models simulated and verified.

Assisted-by: Claude Opus 5.5
@sjoelund
sjoelund merged commit 4c7e384 into master Nov 17, 2026
7 checks passed
@sjoelund
sjoelund deleted the nonstandard-modelica branch November 17, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mark models that need non-standard Modelica as invalid

1 participant