Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6 tasks
This was referenced Nov 5, 2026
Once a distance below 1e-16 has returned, the core-axis test needs a distance below 1e-24 * 4 alpha nu / va, so an inflow under 7e-13 m/s. A solve refuses zero inflow before it builds the influence matrices. The docstring named the wrong function and arguments; it now gives the right ones and says what happens inside the core. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 tasks done
From the #318 branch: Gaunaa et al. 2026's straight elliptic wing reaches 1 with the quarter-chord flow turning the force, and stays below 0.8 without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The reference test left V3 out of its relaxation check. Julia scanned 1 degree forward differences where Python takes 0.5 degree central differences at the table's angles, which gave 0.0214 against 0.0232. The rule is now Python's on vector polars, sharing one slope definition with the artificial viscosity, and all nine cases match to 1e-12. Tests the branch owed: default iterations converge and a repeat solve stays small, the reference inflow, a new inflow keeps the correction, the closed-form limit and a named factor, a panel in still air keeps its wake, the moment of the leg forces, and the two coefficient literals the change had moved inside their tolerance. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
From Two things for your card and diff, from #399 (whose #408 now closes in favour of #415): (1) #415 settles both findings of #399 -- the NaN on the axis is gone and the core model is a deliberate match to Python -- so please end the card on |
6 tasks done
Both trailing vortex kernels computed sqrt(4 ALPHA0 NU distance / va) inline; they now call lamb_oseen_core_radius. Also wraps cross3!'s signature to the line width. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Julia was translated from Python v1.0.0, and Python's v2.3.0 changed its default results. On swept and curved wings, which is every kite, the two had drifted several percent apart. With this branch, Julia matches Python's circulation, angles, per-panel forces and moments, totals and coefficients to six digits on nine reference cases generated by running the Python code, with both solved to a tight stop. At the default stop, circulation, angles and coefficients stay within 1e-5 of those results.
What moved: circulation now follows the effective speed. The chord and chordwise axis are measured square to the bound vortex. Forces turn with the flow at the quarter chord, including a correction for a curved bound vortex, and drag runs along that flow. The force on the chordwise legs is on by default and shared per section boundary. Each wake follows its own panel's inflow, and reference pressure and directions leave out body rates. The defaults also change to 5000 iterations and a relaxation factor of 0.8 of the stability limit, read off the polar the way Python does, so the curved reference wing that used to diverge now converges.
The same default change ends the lost induced drag of #318: the straight elliptic wing of aspect ratio 4 from Gaunaa, Li & Pirrung 2026 now reaches an Oswald efficiency of 0.9947, against 0.7295 with the quarter-chord force direction off.
Agreeing with Python does not make swept wings right. Against that paper's vortex-lattice results, Oswald efficiency is off by −8.2 % at 15 % sweep, −8.0 % at 10 % sweep with 25 % anhedral and −11.1 % at 25 % sweep, where the solver does not converge. The paper's own model is off by +5.6 %, −0.5 % and +1.1 %. Purely curved wings are off by ±2.4 %. These were measured on the previous head by the task behind #400, whose card plots them, and the chord direction on the swept wings is an assumption. #416 tracks the gap; closing it may mean leaving Python's rule, which is the owner's choice.
This is a breaking change even where the results are more correct: the same input now gives different numbers, and the changelog marks it so. That reaches KiteModels wherever its settings do not name these options. Setting the two force options to false and naming a relaxation factor restores those switches, but not the geometry or circulation changes.
Decisions I made:
clandcdwithin 5.4e-6 of the converged result.Found on the way: faster convergence exposed that unrefined section coefficients were plain means, so they are now area-weighted, with the same code as #402. In that code the section chord becomes area over width, and the section moment becomes the sum of its panels rather than their mean. That moment, and the
linearizeoutputs and Jacobian rows taken from it, now grow with the panels per section. A semi-infinite filament now gives zero rather than NaN on its own axis, as #408 also does. It also counts a point within rounding of its line as on the line, by the rule the finite filament uses; such a point got 1.85e9 m/s at 1e-15 m.This covers default results only, so the issue stays open. The missing features are queued as parts of it, each with its Python tests. Of Python's 198 tests, 84 are pinned in Julia and #417 ports 14 more whose feature already exists; the rest wait on those parts, were declined, or test Python-only mechanics such as its compiler and CasADi. That count comes from reading both suites, not from a run. Left out: bridle drag, which stays in KiteModels as ruled on #113, and the other items declined there (flat area, rotate, cosine circulation, configurable aerodynamic-centre fractions) unless the owner says otherwise.
To act on: stacked on #392, which merges first. It takes a different route from #400, whose rule is not Python's, and from #408's core scaling. It conflicts with #402 in the solver, where the aggregation code is identical. SymbolicAWEModels calls the drag-direction helper with an argument that is now gone, so it needs a one-line change when it raises its bound to the release #392 forces.
Verification
test/verification/test_python_reference.jl: green on nine cases (straight, swept, arc, sideslip, LLT, viscous, body rates, distributed inflow, V3). Red before: run through a script on the unchanged code, since the test itself names functions this branch addstest/verification/test_verification.jl: the aspect-ratio-4 test is green, 24/24 in the file; red with the quarter-chord force direction disabled (0.7295, 23/24)test/bench.jl,test_verification.jl,test_curved_bound_correction.jl,test_forwarddiff.jl; the six a later filament change touches (test_bound_filament.jl,test_panel.jl,test_curved_bound_correction.jl,test_python_reference.jl,test_forwarddiff.jl,test/bench.jl) rerun on an earlier head; the ten files the last fixes touch on the head before this one; on this head both filament test files,test_python_reference.jland the docstest_wing_geometry.jl,test_unrefined_dist.jlandtest_python_reference.jlgreen, no conflicttest_python_reference.jl: the default stop and default iteration limit converge within 1e-5 on all nine cases, and the relaxation factor matches Python to 1e-12, red before on V3 (0.0214 vs 0.0232). A repeat solve stays under 1 kB, red at 4240 B on a first version of that fix.test_semi_infinite_filament.jl: rounding off the line gives zero, red before at three distances.test_forwarddiff.jl: the stability limit is type-stable on dual numbers, red before (Union{Float64, Dual})test_curved_bound_correction.jl: rebuilding the correction allocates under 2 kB, red before the fix, when a V3 solve after a shape change allocated 1,536,208 B at 18 panelscalc_forces!0 Bclis checked against the control-point angle. The NaN assertion on the filament axis is now zero. One trim call tightens its angle tolerance to 1e-6, since its 1e-5 assertion sat at 1.17e-5.test/data/python_reference/generate_reference.pyCloses #318
Closes #399
Opened by
1-Bort-1, an AI agent working for @1-Bart-1.Refs #410 · task
VortexStepMethod.jl-410