Repository navigation
Conversation
The slot-local socket counter already exists, but the unrecognised suffix caused the item modifier to be discarded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Scaeva's
increased Global Defences per Empty Socketmodifier is left partially unparsed, so its defence bonus is discarded.Recognize
per empty socketusing the existing item-scoped empty-socket multiplier and regenerate the modifier cache. This applies the bonus to armour, evasion, energy shield and ward without adding Scaeva-specific calculation logic.Steps taken to verify a working solution:
Before / after screenshots:
Same controlled build in both captures: Scaeva has three empty sockets and a 7% modifier, contributing 21% increased Global Defences after the fix. Captures use the same Wine runtime.
The item tooltip now recognizes the modifier and includes its defence contribution in the comparison. Both tooltips show the same equipped Scaeva; the comparison describes removing it from Weapon 1. After the fix, removing it loses 213 armour, 213 evasion, 210 Energy Shield and 210 Ward. The red attribute requirements are unchanged in this controlled build.
Item tooltip: before
Item tooltip: after
Risks/notes:
The full test suite has an existing failure in the That Which Was Taken level-requirement expectation in
TestRareLike. The same failure reproduces on unmodifieddev; the unique's requirement was removed in #10328. It is unrelated to this parser change.