Skip to content

Fix Inc. from Tree and Total from Tree missing conditional tree mods - #10413

Open
mcagnion wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
mcagnion:bugfix/inc-from-tree-source-filter
Open

mcagnion wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
mcagnion:bugfix/inc-from-tree-source-filter

Conversation

@mcagnion

@mcagnion mcagnion commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #8836 .

Description of the problem being solved:

Per-source values in the Calcs tab, such as Inc. from Tree, the Total from Tree line of a breakdown hover, and sidebar lines such as %Inc Life from Tree, query the mods with a source filter. That filter was also applied when each mod's tags read multipliers and conditions, so a tree mod whose tag depends on something from another source read it as missing:

The source filter now only selects which mods a query reads. Their tags read multipliers and conditions from the whole character, as the unfiltered Total Increased breakdown already does. Totals used for damage and defences do not change, only the per-source values. Four CalcPerform queries also filter on the Skill source (Elusive, Shock, Chill and Scorch effect), but no mod they read currently has a multiplier or condition tag, so their results stay the same.

PoB for PoE2 has the same problem: its EvalMod also passes the source filter to the multipliers and conditions read by tags.

Steps taken to verify a working solution:

  • Added a ModStore test: a tree mod scaled by a socket multiplier coming from an item counts in a Tree filtered sum. It fails without the fix.
  • Issue build: MH Total Increased breakdown, Total from Tree goes from 204% to 244%, the sum of its tree rows. DPS unchanged.
  • Rare Long Staff with R-B sockets and Staff Mastery: Life and Mana Inc. from Tree go from 0% to 12%, and the sidebar gains %Inc Life from Tree and %Inc Mana from Tree at 12%. Life and Mana totals unchanged. The Compare tab shows the same values for that build.
  • Compared every output of several real builds, each socket group as main skill, before and after: only the %Inc ... from Tree sidebar values changed.

Link to a build that showcases this PR:

https://pobb.in/xmP5sEohsISQ (from the issue)

Before and after screenshots:

Issue build: Total from Tree in the MH Total Increased breakdown

Before:

before-total-from-tree

After:

after-total-from-tree

Rare Long Staff with R-B sockets and Staff Mastery

Before After
before-life-mana-inc-from-tree after-life-mana-inc-from-tree
before-sidebar-inc-from-tree after-sidebar-inc-from-tree

Queries filtered by source also applied the filter to the multipliers
and conditions read by each mod's tags. Tree mods scaled by weapon
sockets then read 0 sockets and dropped out of the Inc. from Tree lines
and of sidebar lines such as %Inc Life from Tree. The source now only
selects which mods a query reads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cluster Notable Smite the Weak not being properly accounted for in Calc Tab details

1 participant