Repository navigation
Conversation
Queries filtered by source also applied the filter to the multipliers and conditions read by each mod's tags. Tree mods scaled by weapon sockets then read 0 sockets and dropped out of the Inc. from Tree lines and of sidebar lines such as %Inc Life from Tree. The source now only selects which mods a query reads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8836 .
Description of the problem being solved:
Per-source values in the Calcs tab, such as
Inc. from Tree, theTotal from Treeline of a breakdown hover, and sidebar lines such as%Inc Life from Tree, query the mods with a source filter. That filter was also applied when each mod's tags read multipliers and conditions, so a tree mod whose tag depends on something from another source read it as missing:Total from Treeshowed 204% instead of 244% (Cluster Notable Smite the Weak not being properly accounted for in Calc Tab details #8836).Inc. from Treeread 0% instead of 12%, and the sidebar lines were missing. The Two Hand Mastery socket line proposed in PR 10409 has the same problem.The source filter now only selects which mods a query reads. Their tags read multipliers and conditions from the whole character, as the unfiltered
Total Increasedbreakdown already does. Totals used for damage and defences do not change, only the per-source values. FourCalcPerformqueries also filter on theSkillsource (Elusive, Shock, Chill and Scorch effect), but no mod they read currently has a multiplier or condition tag, so their results stay the same.PoB for PoE2 has the same problem: its
EvalModalso passes the source filter to the multipliers and conditions read by tags.Steps taken to verify a working solution:
Treefiltered sum. It fails without the fix.MH Total Increasedbreakdown,Total from Treegoes from 204% to 244%, the sum of its tree rows. DPS unchanged.Inc. from Treego from 0% to 12%, and the sidebar gains%Inc Life from Treeand%Inc Mana from Treeat 12%. Life and Mana totals unchanged. The Compare tab shows the same values for that build.%Inc ... from Treesidebar values changed.Link to a build that showcases this PR:
https://pobb.in/xmP5sEohsISQ (from the issue)
Before and after screenshots:
Issue build:
Total from Treein theMH Total IncreasedbreakdownBefore:
After:
Rare Long Staff with R-B sockets and Staff Mastery