Repository navigation
Conversation
The keystone's three "while you have a Zombie/Skeleton/Spectre" lines were unsupported or restricted to the gem of that name: - Minions take 10% less Damage while you have a Zombie - Minions deal 10% more Damage while you have a Skeleton - Minions gain 10% of Non-Chaos Damage as extra Chaos Damage while you have a Spectre Parse them as minion modifiers gated on a parent condition, and set HaveZombie, HaveSkeleton and HaveSpectre in the minion count loop when an active skill has a positive limit for that minion type. Update the ModCache entries of these lines. Their joined multi-line keys no longer exist, which also moves one chunk boundary.
mcagnion
marked this pull request as ready for review
November 8, 2026 13:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
The Loyal Few, a keystone added by the new Abyss timeless jewels in #10095, has three conditional minion lines that PoB did not parse, so they showed as "Not supported in PoB yet" and changed nothing:
Minions take 10% less Damage while you have a ZombieMinions deal 10% more Damage while you have a SkeletonMinions gain 10% of Non-Chaos Damage as extra Chaos Damage while you have a SpectreEach line now applies to all minions while the player has a minion of the named type. The player gets
Condition:HaveZombie,HaveSkeletonorHaveSpectrefrom the existing minion count loop incalcs.perform: a skill in an enabled group whose Zombie, Skeleton or Spectre limit is above 0 sets it. The minion mods read the condition from their parent, like the existing physical golem line does.PoB has no count of minions currently alive, so "while you have a Zombie" means the build has an enabled skill that summons them with a limit above 0. A minion from a source without a minion list is not seen.
The fourth line of the keystone,
Maximum number of raised Spectres, Skeletons and Zombies is 1, is handled in #10412 and stays unsupported here.Steps taken to verify a working solution:
DamageTakenMore goes from 1 to 0.9 with Raise Zombie,DamageMore from 1 to 1.1 with Summon Skeletons, and the Chaos gain from 0 to 10 with Raise Spectre.Before screenshot:
The Loyal Few on dev:
Minion stats on dev:
After screenshot:
The Loyal Few on this branch:
Minion stats on this branch: