Repository navigation
Conversation
Parse the notable's Ash and Frost modifiers with the existing enemy ailment conditions, preserving the ring-slot restrictions and shared coverage cap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Reliquarian's Polaric Devastation grants ailment duration, but its Ash and Frost lines are not recognised. Add support for those lines using the existing enemy Ignited/Frozen conditions. The notable does not require a ring slot; the Polaric Devastation ring retains its slot restrictions.
Steps taken to verify a working solution:
Reproduction builds:
The minimal reproduction builds use level-one gems and no equipment. The screenshots show UI-rounded values.
Fireball with the enemy Ignited
The fire-hit breakdown attributes 20% increased Fire Damage Taken to Covered in Ash. With 50% enemy resistance, the effective modifier is
0.50 × 1.20 = 0.600.The allocated notable's tooltip below shows removal deltas for the whole node, including its ailment-duration modifier, in the same Ignited Fireball configuration:
Freezing Pulse with the enemy Frozen
The cold-hit breakdown attributes 20% increased Cold Damage Taken to Covered in Frost, with the same
0.50 × 1.20 = 0.600effective modifier.