Repository navigation
Conversation
Passive tree lines granting increased Defences raise Armour, Evasion, Energy Shield and Ward, but the Calcs "Inc. from Tree" rows and the sidebar "%Inc Armour/Evasion/ES from Tree" stats left them out, so those figures read below what the tree gives.
mcagnion
marked this pull request as draft
November 8, 2026 11:52
mcagnion
marked this pull request as ready for review
November 8, 2026 13:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
The
Inc. from Treerows of the Armour, Evasion, Energy Shield and Ward sections in the Calcs tab, and the sidebar lines%Inc Armour from Tree,%Inc Evasion from Treeand%Inc ES from Tree, did not count passive tree lines granting increased Defences. The defence calculation and theTotal Increasedrows already count them, so these figures read below what the tree gives, or 0% on a build whose only tree investment is such a line.These rows and sidebar lines now include
Defences. Only the displayed per-source values change: Armour, Evasion, Energy Shield and Ward totals stay the same.The closest precedent is Openarl/PathOfBuilding issue 273, after which the sidebar stats started counting increased Evasion Rating and Armour. Global Defences lines on the tree came later.
Steps taken to verify a working solution:
Inc. from Treego from 0% to 40%, Energy Shield from 35% to 75%. Hovering a value lists the Defences line and its source. The sidebar gains%Inc Armour from Treeand%Inc Evasion from Treeat 40%, and%Inc ES from Treegoes from 35% to 75%.Total Increasedrows do not change.Inc. from Treematches the sum of the tree rows ofTotal Increased.Before and after screenshots:
Level 97 Witch with 40% increased Defences from the tree.
Hover of the Armour
Inc. from Treevalue after the fix: