Skip to content

Count tree Defences in the Inc. from Tree stats - #10416

Open
mcagnion wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
mcagnion:bugfix/inc-from-tree-defences
Open

mcagnion wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
mcagnion:bugfix/inc-from-tree-defences

Conversation

@mcagnion

@mcagnion mcagnion commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

The Inc. from Tree rows of the Armour, Evasion, Energy Shield and Ward sections in the Calcs tab, and the sidebar lines %Inc Armour from Tree, %Inc Evasion from Tree and %Inc ES from Tree, did not count passive tree lines granting increased Defences. The defence calculation and the Total Increased rows already count them, so these figures read below what the tree gives, or 0% on a build whose only tree investment is such a line.

These rows and sidebar lines now include Defences. Only the displayed per-source values change: Armour, Evasion, Energy Shield and Ward totals stay the same.

The closest precedent is Openarl/PathOfBuilding issue 273, after which the sidebar stats started counting increased Evasion Rating and Armour. Global Defences lines on the tree came later.

Steps taken to verify a working solution:

  • Added a test that allocates a passive granting only increased Defences and checks the four Calcs rows and the three sidebar values. It fails without the fix.
  • Build with 40% increased Defences from the tree: Armour, Evasion and Ward Inc. from Tree go from 0% to 40%, Energy Shield from 35% to 75%. Hovering a value lists the Defences line and its source. The sidebar gains %Inc Armour from Tree and %Inc Evasion from Tree at 40%, and %Inc ES from Tree goes from 35% to 75%.
  • On that build, the Armour, Evasion, Energy Shield and Ward totals and their Total Increased rows do not change.
  • On several real builds, Inc. from Tree matches the sum of the tree rows of Total Increased.

Before and after screenshots:

Level 97 Witch with 40% increased Defences from the tree.

Before After
before-armour-evasion-inc-from-tree after-armour-evasion-inc-from-tree
before-es-ward-inc-from-tree after-es-ward-inc-from-tree
before-sidebar-inc-from-tree after-sidebar-inc-from-tree

Hover of the Armour Inc. from Tree value after the fix:

after-armour-tooltip

Passive tree lines granting increased Defences raise Armour, Evasion,
Energy Shield and Ward, but the Calcs "Inc. from Tree" rows and the
sidebar "%Inc Armour/Evasion/ES from Tree" stats left them out, so
those figures read below what the tree gives.
@mcagnion
mcagnion marked this pull request as draft November 8, 2026 11:52
@mcagnion
mcagnion marked this pull request as ready for review November 8, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant