Repository navigation
Move console_level into pyfaradaycup._logging - #146
Merged
Merged
Conversation
The level of messages printed for the -v/--verbose and -q/--quiet options is not specific to pfc_decommutator, so move it next to configure_logging so that other command line tools can use it. Move its test into tests/test_logging.py and add a case for when both options are given. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
=======================================
Coverage 70.99% 70.99%
=======================================
Files 8 8
Lines 1124 1124
Branches 163 163
=======================================
Hits 798 798
Misses 291 291
Partials 35 35
🚀 New features to boost your workflow:
|
2 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This moves
_console_levelfrompyfaradaycup.decommutator.mainto a publicconsole_levelinpyfaradaycup._logging, next toconfigure_logging. It converts the-v/--verboseand-q/--quietoptions into a logging level, which isn't specific topfc_decommutator. This lets the upcomingpfc_l05_to_l1tool (#136) reuse it. The function's behavior doesn't change.console_levelnow has a full numpydoc docstring.test_console_levelmoves fromtests/decommutator/test_decommutator.pytotests/test_logging.py, and gets a new case where-vand-qare both given (quietwins).This was split out of #136 to make that PR smaller.
🤖 Generated with Claude Code