Repository navigation
Share the CDF metadata comparison as a test fixture - #147
Merged
Merged
Conversation
Move the comparison of CDF metadata that is lost when converting to xarray from the decommutator tests into a cdf_metadata fixture in tests/conftest.py, so that tests of other steps of the pipeline can compare their output CDF files with expected ones in the same way. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This moves
_valueand_cdf_metadatafromtests/decommutator/test_decommutator.pyinto a newtests/conftest.pywithout changing them, and makes the comparison available as thecdf_metadatafixture. The fixture compares the CDF metadata that is lost when converting to xarray. The tests for the upcoming L0.5 → L1 step (#136) need the same comparison.test_pfc_decommutatornow uses the fixture.test_decommutator.pynow usesfrom __future__ import annotationsand importsCallableunderTYPE_CHECKING, the same way asconftest.py.INP001is ignored fortests/**/conftest.py, because the tests directory has no__init__.py.This was split out of #136 to make that PR smaller.
🤖 Generated with Claude Code