Repository navigation
Conversation
The sync endpoint answers with `warnings` alongside `refresh_index`, and `pos-cli sync` never showed them; `pos-cli deploy` already does. The file is still saved; the warning says what the instance found, e.g. that the synced page answers the same route as another page, so only one of them is served (views/pages/marketplace.liquid and views/pages/marketplace/index.liquid both answer /marketplace). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The instance's sync endpoint (
PUT /api/app_builder/marketplace_releases/sync) answers withwarningsnext torefresh_index, butpos-cli syncdropped them;pos-cli deployalready prints its warnings (lib/push.js).A companion platform change (mdyd-dev/desksnearme#11671) makes deploy and sync report pages that answer the same route. For example,
views/pages/marketplace.liquidandviews/pages/marketplace/index.liquidboth answer/marketplace, so only one of them is served and edits to the other do nothing. A partner ran into exactly this: an old page file was resurrected by a sync, then pulled by everyone.What changed
lib/watch.jspushFile: after[Sync] Synced: <path>, prints[Sync] <path>:followed by each warning, vialogger.Warn. The file is still saved; nothing else changes.test/unit/watch.test.js: warnings are printed; an empty list prints nothing.CHANGELOG.md: entry under Unreleased → New Features.Older instances that send no
warnings, or an empty list, behave as before.Not changed
The MCP
sync-filetool (mcp-min/sync/single-file.js) still drops the warnings.Tests
npx vitest run test/unit/watch.test.js: 54 passed.