Repository navigation
Conversation
The French form_name of the three Paldean Tauros breeds was just "Forme de Paldéa", so the breeds could not be told apart. Add the breed in parentheses, like the English and Chinese entries. Also spell the region "Paldea" without an accent in these French entries, as in region_names.csv, location_names.csv and the official French name. Refs PokeAPI#1401
Member
|
Hey @SixStack why did you close? |
Member
|
Likely a duplicate with #1729? |
Member
|
Yeah, I saw it, but we didn't merge any of the two when he closed it. And this one has the removal of the accent from Paldea. @SixStack if you think the accent should be removed feel free to one a new PR. |
4 tasks done
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The French form names of the three Paldean Tauros breeds were all just "Forme de Paldéa", so you couldn't tell them apart. I added the breed, like in English:
I also removed the accent in "Paldéa" in these rows and in Paldean Wooper (forms 10419-10422). The region is spelled "Paldea" everywhere else in the data (region_names, location_names) and on Poképédia.
Partially fixes #1401: the Japanese names still don't include the breed, I left them as is because I'm not sure of the official spelling.