Repository navigation
Pin which ids the grid and location layers set on their own - #83
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (anchored on CI run 43379783188 at head 9b92ad1)
src/tests.cpp, Test 85 — the address-range check compares pointers into one vector, which is well-defined; it would not detect a reference to a stale copy only if the copy happened to sit inside that range, which cannot happen for a separate allocation. Do-not-auto-merge paths: none touched (no Makefile, workflow, or security path; no file loses more than 50 lines). This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage B (unit-test expansion) cycle, with the matching README sentence. No production code is changed.
Grid::addEntitysets the grid id and location id but leaves the environment id at -1, thatGrid::removeEntityresets the grid id and location id but leaves an environment id unchanged, and thatLocation::addEntity/Location::removeEntityset and reset only the location id, leaving grid and environment ids alone.Grid::getRandomLocationreturns a reference into the grid's ownstd::vector<Location>(100 draws, each checked to lie between the first and last element), and that an entity added through that reference is present in the grid.Environmentbehaviour was stated.No tracking issue — gap found during triage (the open-issue backlog was empty).
Test plan
Local compilation and execution are refused in this sandbox, so the CI job serves as the anchor.
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson