Repository navigation
Pin what printInfo prints and that grid presence matches by id - #84
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (anchored on CI run 43679339198, "Library tests (make + CMake)"):
Judgment notes:
No blocking findings. Local binary execution is blocked in this sandbox, so CI served as the anchor. This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Environment::printInfo():=== <name> ===followed byNum entities: <n>, where the name is the current one aftersetNameand<n>counts stored pointers, so an entity added twice is counted twice. The existing Test 28 only checks for substrings.Grid::isEntityPresent, called on a standaloneGrid, reports a same-id twin of a stored entity as present, and that the lookup leaves the twin's own ids untouched. Until now, presence matching by id was only checked at theLocationandEnvironmentlevel.README.mdnow states whatprintInfo()prints (it was not documented anywhere), and the "Entity Identity" section now listsGrid::isEntityPresentandEnvironment::isEntityPresentamong the methods that compare ids.No production code is changed. This cycle is a Stage B unit-test expansion plus a small Stage A documentation fix. No tracking issue exists, since the open-issue backlog was empty at triage and the gap was found during the coverage sweep.
Test plan
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson