Repository navigation
Nest --exit-after-create inside the grid size in main.py's usage line - #68
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (performed inline. No independent reviewer was available in this headless run):
Inline notes:
This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main.py's usage line is changed from[gridSize] [--exit-after-create]to[gridSize [--exit-after-create]], so the flag is shown as following a grid size. This matchesparseArgs, which reads the flag only as the second argument. Direction 1 from the issue was chosen because it changes no behaviour:create_environments.batalready passes the flag second, and theTestParseArgscharacterization tests (includingtest_the_flag_given_first_is_read_as_an_invalid_grid_size) still hold unchanged.TestCliEntrypointusage assertion is updated to the new string.Runningsection now quotes the usage line and explains what the nested brackets mean. The existing paragraph about where the flag is read already describes the positional rule.Closes #67
Deferred issues
Vironsubmodule pointer cannot be changed without explicit authorization.Test plan
python3 -m py_compile main.py graphik.py __init__.pypython3 -m unittest discover -s tests: Ran 209 tests, OKmain.py,tests.test_mainfails three subtests (--help,-h,100 --help). With the change, it passes.Testsworkflow green on this headThis PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson