Repository navigation
fix: Escape string literals in infer_schema.py - #425
Merged
Merged
Conversation
Andreas Albert (AndreasAlbertQC)
requested review from
Oliver Borchert (borchero) and
Daniel Elsner (delsner)
as code owners
November 18, 2026 15:41
Daniel Elsner (delsner)
approved these changes
Nov 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 46 46
Lines 2587 2592 +5
=========================================
+ Hits 2587 2592 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Both new tests omit the Arrange, Act, and Assert markers required by the repository’s testing guidelines.
1 open issue
What changed in this PR
This PR hardens experimental schema generation by escaping untrusted string values before inserting them into generated Python code.
Changes:
- Adds a shared string-literal helper for aliases, struct field names, and temporal type arguments.
- Adds regression coverage for special characters, injection payloads, and escaped output formatting.
| File | Description |
|---|---|
| tests/experimental/test_infer_schema.py | Tests escaping, injection prevention, and generated formatting. |
| dataframely/experimental/infer_schema.py | Safely renders string literals using repr while preserving preferred quoting where possible. |
Review effort: Balanced
Andreas Albert (AndreasAlbertQC)
enabled auto-merge (squash)
November 18, 2026 15:58
Andreas Albert (AndreasAlbertQC)
disabled auto-merge
November 18, 2026 16:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
The experimental
infer_schemafeature currently passes through unvalidated user input into code generation logic. While the code is not executed by the library, and is meant for review by the caller, we still want to avoid allowing code injection opportunities here.Changes
infer_schema