Repository navigation
Publish build dir changes to official-images - #305
Merged
Merged
Conversation
The manifest comparison ignored GitCommit lines, so the workflow only opened an official-images PR when tags, directories, or architectures changed. Changes to files in the build dirs, like the entrypoint fix for #301, were never published. Also open the PR when target/ changed between the published commit and ours. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix for #301 merged in #304 but never reached
docker-library/official-images.library/clojurestill points atbe6ebe7, so the published images still have the old entrypoint.The official-images workflow compares our generated manifest with the published one and ignores
GitCommitlines, since those always differ. The manifest only lists tags, directories, and architectures, so a PR was only opened when one of those changed. #304 changed only theentrypointfile inside existing build dirs, so the comparison found nothing (run:open-official-images-prwas skipped). Any earlier change to files in the build dirs, without a tag change, would have been skipped the same way.Change
The compare job also checks out this repo with full history. If the manifests match apart from
GitCommit, it runsgit diffontarget/between the published commit and the one in our manifest, and opens the PR if they differ. Merges that don't touchtarget/(README, tests, CI) still don't open a PR. If the published commit is missing from our history, the job treats it as changed and opens the PR.Testing
I extracted the new step's script from the workflow and ran it against the live
library/clojuremanifest and this repo's history:46f4b00(master, #304 regenerated)be6ebe73ad9bed(target/same as published)be6ebe746f4b003ad9bed+ an added tagbe6ebe7After this merges, its CI run should trigger the workflow, which should open the official-images PR for #301 because
target/has changed sincebe6ebe7.🤖 Generated with Claude Code