Repository navigation
fix(ci): restore explicit lintr and styler test dependencies - #1933
Merged
eitsupi merged 1 commit intoNov 13, 2026
Merged
Conversation
eitsupi
approved these changes
Nov 13, 2026
renkun-ken
reviewed
Nov 13, 2026
renkun-ken
left a comment
Member
There was a problem hiding this comment.
Reviewed 4134033. The explicit any::lintr and any::styler entries address the missing optional dependencies; I found no issue with the change.
The Ubuntu retry missed the R package cache, installed lintr 3.4.0 and styler 1.11.0, and passed the Interactive linting and formatting tests. Windows, build, format, and lint checks also passed.
The first macOS attempt also installed both packages after a cache miss, but five Interactive tests failed, including input linting and formatting timeouts. The macOS retry is still running. The cause of those failures is unclear from the logs, so please check the retry before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore
any::lintrandany::stylerin the test job's R dependencies so Interactive linting and formatting tests work with a fresh R library.Both packages were explicitly installed before #1932. That PR initially preserved them when switching to
setup-r-dependencies, but commit 6a4f2a6 removed them. They are optional (Suggests) dependencies oflanguageserver, and the dependency installation did not include them.lintr3.4.0 andstyler1.11.0, masking the missing explicit dependencies.languageserverbut neitherlintrnorstyler. Five diagnostic tests timed out, and formatting reportedBackend 'styler' requires styler >= 1.5.1. The seventh failure was a draft-preservation assertion, likely cascading from input left behind by earlier failed tests.