Skip to content

fix(ci): restore explicit lintr and styler test dependencies - #1933

Merged
eitsupi merged 1 commit into
REditorSupport:mainfrom
Fred-Wu:fix/restore-interactive-ci-dependencies
Nov 13, 2026
Merged

eitsupi merged 1 commit into
REditorSupport:mainfrom
Fred-Wu:fix/restore-interactive-ci-dependencies

Conversation

@Fred-Wu

@Fred-Wu Fred-Wu commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Restore any::lintr and any::styler in the test job's R dependencies so Interactive linting and formatting tests work with a fresh R library.

Both packages were explicitly installed before #1932. That PR initially preserved them when switching to setup-r-dependencies, but commit 6a4f2a6 removed them. They are optional (Suggests) dependencies of languageserver, and the dependency installation did not include them.

  • The final PR run restored older R package caches on both Ubuntu and macOS. Their installed-package listings included lintr 3.4.0 and styler 1.11.0, masking the missing explicit dependencies.
  • The post-merge run reported R package cache misses on both platforms. Its fresh libraries contained languageserver but neither lintr nor styler. Five diagnostic tests timed out, and formatting reported Backend 'styler' requires styler >= 1.5.1. The seventh failure was a draft-preservation assertion, likely cascading from input left behind by earlier failed tests.
  • The merge commit and final PR head have the same Git tree. The cache contents, rather than a merge-time source change, explain the different dependency availability.
  • Windows stayed green because the affected Interactive integration suite is skipped there. Node and plot lifecycle tests passed on both failing platforms.

@renkun-ken renkun-ken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4134033. The explicit any::lintr and any::styler entries address the missing optional dependencies; I found no issue with the change.

The Ubuntu retry missed the R package cache, installed lintr 3.4.0 and styler 1.11.0, and passed the Interactive linting and formatting tests. Windows, build, format, and lint checks also passed.

The first macOS attempt also installed both packages after a cache miss, but five Interactive tests failed, including input linting and formatting timeouts. The macOS retry is still running. The cause of those failures is unclear from the logs, so please check the retry before merging.

@eitsupi
eitsupi merged commit 86e9fe9 into REditorSupport:main Nov 13, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants