Skip to content

fix: render nested inline elements in formatting spans - #1439

Open
gitseraj wants to merge 1 commit into
RocketChat:developfrom
gitseraj:fix/nested-inline-elements
Open

gitseraj wants to merge 1 commit into
RocketChat:developfrom
gitseraj:fix/nested-inline-elements

Conversation

@gitseraj

@gitseraj gitseraj commented Nov 17, 2026 •

Copy link
Copy Markdown

Fix nested inline elements inside formatting spans

Acceptance Criteria fulfillment

  • Render inline code, emoji, channel mentions, and user mentions inside bold formatting.
  • Render inline code, emoji, channel mentions, and user mentions inside italic formatting.
  • Render inline code, emoji, channel mentions, user mentions, and timestamps inside strikethrough formatting.

Fixes #1429

Video/Screenshots

Not provided. This change affects inline rendering and can be verified through the package.

PR Test Details

  • Markups package build passed.
  • ESLint passed for all three modified files.
  • git diff --check passed.
  • Regression tests have not yet been added.

@CLAassistant

CLAassistant commented Nov 17, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@gitseraj

gitseraj commented Nov 17, 2026 •

Copy link
Copy Markdown
Author

@Aryan-Verma-999 I couldn't find an existing test setup for the @embeddedchat/markups package. Would you prefer that I add regression tests as part of this PR
If yes could you point me to the preferred testing approach?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nested inline code, emoji and mentions disappear inside bold, italic and strikethrough

2 participants