Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(react): improve form accessibility and input labeling
Acceptance Criteria fulfillment
id,name, and descriptivearia-label="Upload file"to the hidden file input inChatInput.js.LoginForm.jsfrom<div>tags to semantic<label htmlFor="...">elements with correspondingidandnameattributes.LoginForm.jskeyboard handling by replacing deprecatedonKeyPresswithonKeyDown.<Box is="button" ...>with dynamicaria-label.name,id,autoComplete="one-time-code", accessible label, and Enter-key submission toTwoFactorTotpModal.js.name,id, and descriptivearia-labelattributes to inputs inInsertLinkToolBox.jsandMessageReportWindow.js.@embeddedchat/reactversion tracking.yarn lint) and clean production build (yarn build).Fixes #1441
Video/Screenshots
Before (Browser Audit Warning):
After (Warning Resolved):
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-1442 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.