Skip to content

fix(react): improve form accessibility and input labeling - #1442

Open
Siddh2024 wants to merge 1 commit into
RocketChat:developfrom
Siddh2024:fix/a11y-form-inputs
Open

Siddh2024 wants to merge 1 commit into
RocketChat:developfrom
Siddh2024:fix/a11y-form-inputs

Conversation

@Siddh2024

@Siddh2024 Siddh2024 commented Nov 18, 2026 •

Copy link
Copy Markdown

fix(react): improve form accessibility and input labeling

Acceptance Criteria fulfillment

  • Added id, name, and descriptive aria-label="Upload file" to the hidden file input in ChatInput.js.
  • Converted field label wrappers in LoginForm.js from <div> tags to semantic <label htmlFor="..."> elements with corresponding id and name attributes.
  • Modernized LoginForm.js keyboard handling by replacing deprecated onKeyPress with onKeyDown.
  • Made password visibility toggle an accessible <Box is="button" ...> with dynamic aria-label.
  • Added name, id, autoComplete="one-time-code", accessible label, and Enter-key submission to TwoFactorTotpModal.js.
  • Added name, id, and descriptive aria-label attributes to inputs in InsertLinkToolBox.js and MessageReportWindow.js.
  • Added Changeset for @embeddedchat/react version tracking.
  • Verified 0 lint errors (yarn lint) and clean production build (yarn build).

Fixes #1441

Video/Screenshots

Before (Browser Audit Warning):

Screenshot 2026-11-18 215642

After (Warning Resolved):

Screenshot 2026-11-18 220546

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-1442 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@CLAassistant

CLAassistant commented Nov 18, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Missing form accessibility attributes, semantic labels, and deprecated event handlers in React views

2 participants