Repository navigation
Fix directory path created by author server deploy - #1657
Closed
ascholerChemeketa wants to merge 1 commit into
Closed
ascholerChemeketa wants to merge 1 commit into
ascholerChemeketa wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the deployment-directory path correction.
No open issues 🎉
What changed in this PR
Corrects the author server’s deployment directory path so it creates the intended nested directory instead of an unwanted published{book} directory.
Changes:
- Adds the missing slash between
publishedand the book name in the remotemkdir -pcommand.
| File | Description |
|---|---|
bases/rsptx/author_server_api/worker.py |
Corrects the deployment directory to ~/books/{book}/published/{book}. |
Review effort: Balanced
Member
|
Thanks, I had already done this locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like this just creates a cruft directory
publishedbookas the subsequent rsync to{book}/publishedshould create the missing directory level. Thus the copy works, but leaves behind an unwanted/needed directory.