Skip to content

.env is missing from .dockerignore #369

Open

Description

@SDL-A1

.dockerignore excludes .git/, target/, *.log, data, dist, bin,
docs, tools and *.md — but not .env.

docker/build.Dockerfile does COPY . ., and docs/docker.md instructs
operators to create .env from .env.example. So a machine that has been
set up to run the node and then builds a binary copies its own .env into
the build context.

It does not reach the shipped artifact: the export target is FROM scratch
and contains only the binary. But it lands in build layers and the local
image cache, and would be present in the build image if that image were ever
pushed.

Today .env holds ports, a network id and an external IP — nothing secret.
The problem is the convention: .env is where secrets accumulate, and the
file is being introduced to this repository for the first time by the same
change that leaves it out of the ignore list.

One line:

.env

Arrived with #366.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions