You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
build-binary.sh word-splits TOOLS, breaking its own documented usage #370
which contains a space. The likely result is that docker buildx build
receives --build-arg, TOOLS=rewind_to and a stray block_info as
separate arguments.
bash -n passes, because this is a semantic problem rather than a syntax
one, which is why the pull request's own checks did not catch it.
The default path is unaffected: TOOLS is set as an ARG inside docker/build.Dockerfile, so the script only passes it when an operator
overrides it — exactly the documented case.
Worth confirming with the documented invocation before changing anything, in
case bash's handling of quotes inside ${parameter:+word} makes it work
after all. If it does break, the fix is to build the arguments in an array:
Two arguments, not three. The space inside TOOLS survives because the inner quoting is real quoting rather than literal characters; the only split point is the unquoted space between --build-arg and "TOOLS=...", which is exactly the split we want.
One thing worth leaving on the record: this would be a real bug under a #!/bin/sh shebang on a shell that does not treat those inner quotes as quoting. The bash shebang is load-bearing here and should not be downgraded casually.
Activity
SDL-A1 commentedon Nov 18, 2026
Not a defect. Tested rather than reasoned about, since the issue text asked for exactly that confirmation before changing anything.
scripts/build-binary.shis#!/bin/bash, and bash honours the quotes inside${parameter:+word}:Two arguments, not three. The space inside
TOOLSsurvives because the inner quoting is real quoting rather than literal characters; the only split point is the unquoted space between--build-argand"TOOLS=...", which is exactly the split we want.So the documented invocation
works as written. Closing with no change.
One thing worth leaving on the record: this would be a real bug under a
#!/bin/shshebang on a shell that does not treat those inner quotes as quoting. Thebashshebang is load-bearing here and should not be downgraded casually.