You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Three regression tests for real mainnet stalls were deleted, including #9,251,058 #379
9_251_058 no longer appears anywhere in the PR's sources. That height is the
mainnet stall that wedged this node for three days — the PR's own source
comment records it as the reason the orphan-adoption path existed.
The specific worry
These guarded real, observed production failures. The PR replaces the mechanism
they covered, which is a legitimate reason for them to change — but the
replacements (beside-execution tests) are synthetic, and the mainnet chain
replay feeds blocks in canonical order, so it never exercises a live fork.
So the thing that broke mainnet twice has no regression test keyed to it any more.
What would settle it
Port the three removed cases to the new mechanism, or demonstrate that a beside-execution test covers each one's scenario. If a case is genuinely
unreachable under the new design, say so in a comment where the test used to be,
with the reasoning.
Activity