Skip to content

Pre-RSKIP136: a precompile call can be rejected below #3,397 where RSKj accepts it #381

Open

Description

@SDL-A1

From the external review of #374. crates/execution/src/executor.rs:2296-2320.

Below mainnet #3,397 (pre-RSKIP136), a direct precompile call whose fee
exceeds the sender's balance is refused. RSKj lets the balance go negative and
accepts the block.

A rule stricter than the chain it must accept is a fork, so if any block below
#3,397 hits this, replay from genesis diverges.

The PR documents this itself, which is the right thing to have done — it is a
known divergence, not a hidden one.

What would settle it

Scan mainnet blocks 0..3,397 for a direct precompile call whose fee exceeds the
sender's balance. 3,397 blocks is nothing; this is a cheap question to answer
definitively rather than leave open.

If a block does hit it, the rule has to match RSKj. If none does, record the scan
in a comment so the next reader knows it was checked rather than assumed.

Related: #295 (pre-RSKIP197 throwing precompiles).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions