You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
has_rskip535 enables at block 1 for every chain id outside 30/31 #385
RSKj turns RSKIP535 on at block 1 only on regtest. Here the catch-all arm
covers regtest (33) and every other chain id, including the synthetic ids the
tests use and any future network.
Mainnet and testnet are not affected — they have explicit arms. So there is
no consensus impact today.
Why fix it anyway
A catch-all that silently enables a consensus rule is the kind of default that is
correct until someone adds a chain. The same file already got this treatment in #214, where per-chain heights were pulled into named constants precisely so an
unknown chain could not inherit a rule by accident.
What would settle it
Name regtest explicitly and make the remaining arm either false or an
explicit panic/unreachable! with a comment saying which ids are expected.
Activity