Repository navigation
Move past the lettre STARTTLS and dot-stuffing advisories - #375
Merged
Merged
Conversation
cargo-deny's advisories check failed on three RUSTSEC advisories published against lettre 0.11.23, which the smtp feature builds into rustock-alerts and so into the node binary: - RUSTSEC-2026-0560: a man-in-the-middle appends replies to the cleartext reply to STARTTLS, and the client takes them for the server's replies to the commands it then sends over TLS. A message the server rejected can be made to look accepted. Only STARTTLS connections are affected (Tls::Required and Tls::Opportunistic, as `starttls_relay` sets up, which `TlsMode::Starttls` selects in crates/alerts/src/sink.rs); implicit TLS is not. - RUSTSEC-2026-0561: missing dot-stuffing after a bare LF or CR allows SMTP command injection. - A panic on an EHLO reply line of only white space, a denial of service. All three are fixed in 0.11.24. `cargo update -p lettre` takes email-encoding 0.4.3 with it, which carries the dot-stuffing fix. Lockfile only: no manifest changes, and the package count is unchanged at 469, with nothing added or removed beyond those two versions. Cargo's re-resolution also moves errno, rustix and tempfile from windows-sys 0.52.0 to 0.61.2; both were already locked, and both remain. `cargo metadata --locked` passes and every dependency outside the workspace still carries a checksum (459 of 469, the other 10 being the workspace members), which is what the Security workflow asserts. Found by the advisories job on #374, not by the daily schedule in security.yml: that cron has never fired since it was added on 11 September 2026 (0 scheduled runs repository-wide). Filed separately. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo-deny's advisories check fails on three RUSTSEC advisories published againstlettre 0.11.23. Thesmtpfeature builds it intorustock-alertsand so into the node binary, and that is the configuration the production node runs.STARTTLS; the client takes them for the server's replies to the commands it then sends over TLS, so a message the server rejected can be made to look accepted.EHLOreply line of only white space: a denial of service.All three are fixed in
0.11.24.RUSTSEC-2026-0560 affects
STARTTLSconnections only —Tls::RequiredandTls::Opportunistic, whichstarttls_relaysets up andTlsMode::Starttlsselects incrates/alerts/src/sink.rs. Implicit TLS (relay) is not affected. The production node is configuredtls = "starttls"on port 587 with alerts enabled, so it is in the affected configuration. It was stopped pending this fix.The change
cargo update -p lettre. Lockfile only, no manifest change:lettre0.11.23 -> 0.11.24email-encoding0.4.2 -> 0.4.3, which carries the dot-stuffing fixCargo's re-resolution also moves
errno,rustixandtempfilefromwindows-sys 0.52.0to0.61.2. Both versions were already locked and both remain;--precise 0.11.24produces the identical lockfile, so this is not avoidable by pinning harder.Checked
cargo metadata --lockedpasses.Securityworkflow asserts.How it was found
By the
advisoriesjob on #374, not by the daily schedule insecurity.yml. That cron has never fired: the workflow isstate=activewith the file on the default branch and valid syntax, but there are 0 runs withevent=schedulerepository-wide since it was added on 11 September 2026. Worth filing separately: the schedule is the part meant to catch exactly this class of problem, advisories published against dependencies that are already pinned.🤖 Generated with Claude Code