Repository navigation
pointCollection/grid/data.py : write boolean fields as bytes, with a … - #68
Merged
Merged
Conversation
…nodata value of 255 to_h5 and to_nc created boolean datasets with the NaN fill value used for other fields, which failed, and the exception was swallowed, so boolean fields (e.g. LSsurf's z0 and dz masks) were silently left out of the files. Boolean fields are now written as uint8 (0 and 1) with a fill value of 255; they read back as float. The in-memory fields are unchanged. tests/test_grid_bool_fields.py : tests for the above (h5 and nc, 2-D and 3-D) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nodata value of 255
to_h5 and to_nc created boolean datasets with the NaN fill value used for other fields, which failed, and the exception was swallowed, so boolean fields (e.g. LSsurf's z0 and dz masks) were silently left out of the files. Boolean fields are now written as uint8 (0 and 1) with a fill value of 255; they read back as float. The in-memory fields are unchanged.
tests/test_grid_bool_fields.py : tests for the above (h5 and nc, 2-D and 3-D)