Repository navigation
add catch for image load failure - #796
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues with the image-loading failure-handling change.
No open issues 🎉
What changed in this PR
Adds failure handling to the image pane’s loading promise chain so rejected requests are caught.
Changes:
- Sets the image’s alternative text to “Unable to load image” on failure.
- Logs a warning with the error details.
| File | Description |
|---|---|
src/imagePane.ts |
Adds a catch handler to provide fallback text and log image-loading errors. |
Review effort: Balanced
SharonStrats
force-pushed
the
image-error
branch
from
November 6, 2026 00:51
3160e61 to
b3e13ae
Compare
…@5.0.2-6 pane-registry@5.0.2-2 folder-pane@4.0.1-1 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.