Repository navigation
fix direct url layout view - #797
Open
SharonStrats wants to merge 2 commits into
Open
SharonStrats wants to merge 2 commits into
SharonStrats wants to merge 2 commits into
Conversation
…@5.0.2-6 pane-registry@5.0.2-2 folder-pane@4.0.1-1 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Regression tests are missing for Back-button visibility in solo navigation and ordinary expansion, including after asynchronous menu updates recompose the header.
1 open issue
What changed in this PR
This PR adjusts explorer headers for direct-URL views while preserving Back navigation in embedded outlines.
Changes:
- Hides the resource-header Back button in solo views.
- Suppresses resource headers for all folder views.
- Updates navigation tests to expect hidden folder headers.
| File | Description |
|---|---|
test/unit/navigation/chrome.test.ts |
Updates folder-header visibility expectations. |
src/outline/manager.js |
Sets Back-button visibility based on solo mode. |
src/navigation/chrome.ts |
Suppresses resource headers for every folder pane. |
Review effort: Balanced
| ? { | ||
| paneIcon: getPaneIcon(pane, subject, context), | ||
| menuItems: state.menuItems, | ||
| showBack: !state.options.solo |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for a direct url to a container I have changed it to look like this, there is no longer a file-explorer-header, instead there is a folder-storage-header... so breadcrumbs and can change grid/list no sidebar.
