Repository navigation
add showback option to support direct url - #922
Open
SharonStrats wants to merge 2 commits into
Open
SharonStrats wants to merge 2 commits into
SharonStrats wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change adding configurable Back-button visibility.
No open issues 🎉
What changed in this PR
Adds a showBack option to the file explorer so direct resource views can hide the Back button while preserving its default visibility.
Changes:
- Passes optional
showBackconfiguration through explorer composition and header components. - Adds a test confirming that composition forwards
showBack: false. - Adds a zinc color token and bumps the package version to
5.0.2-7.
| File | Description |
|---|---|
test/components/compose-explorer.test.ts |
Tests forwarding showBack: false to the header. |
src/styles/theme.css |
Adds zinc-300 and groups zinc color tokens. |
src/lib/file-explorer/compose-explorer.ts |
Accepts optional showBack, defaulting to true. |
src/components/file-explorer-header/FileExplorerHeaderSummary.ts |
Conditionally renders the Back button. |
src/components/file-explorer-header/FileExplorerHeader.ts |
Exposes showBack and forwards it to the summary. |
package.json |
Bumps the version to 5.0.2-7. |
package-lock.json |
Synchronizes package version metadata. |
Review effort: Balanced
…istry@5.0.2-2) (latest: rdflib@2.4.1)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for showing the back button so that we can hide it on a direct url since it does not know where to go back to.