Repository navigation
feat: add Corticale SiNAPS probes - #86
Open
claudio-digeronimo wants to merge 1 commit into
Open
claudio-digeronimo wants to merge 1 commit into
claudio-digeronimo wants to merge 1 commit into
Conversation
Added the five SiNAPS Generation II models (M0001-M0005) with their generator script, and registered Corticale in the viewer with logo and grouping.
Member
|
Thanks @claudio-digeronimo Looks good to me! If you want, you can also add the corticale logo on the png, as for cambridge neurotech (See example) |
Member
|
Another suggestion: currently, you define all models here. An alternative way to automate this (say if you add a new probe) could be for you to keep a separate repo with JSON / csv files with the models and we set up a CI action running weekly to see if there are updates. If any update is available, we make an automate PR. This is already in place for Neuropixels and Cambridge Neurotech |
Author
|
Thanks! I'll add the Corticale logo to the PNGs, as for Cambridge NeuroTech. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Corticale SiNAPS Generation II probes (M0001-M0005).
corticale/: one JSON and preview PNG per model, generated byscripts/generate_corticale.pyfrom the Corticale technical datasheet.The same probes already appear as
plexon/(Plexon's names: 1S256, 4S1024, 1S512, 8S1024, 1S512-N) and partly assinaps-research-platform/, both added by third parties, but this PR adds the manufacturer's own catalog undercorticale/, following the Corticale technical datasheet.