Repository navigation
Verify forward issue references in Phase 4 before pushing - #179
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (one intrinsic pass, anchored on CI run 43831124541 and
Judgment call for the reviewer: the paragraph says "run Summary: mechanically clean and CI green; behavioral validation of the template change is outstanding, so the PR is left open for human review rather than merged. This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #Nand closing-keyword checks. It covers the reverse case: a PR body that promises an issue that has not been filed yet ("a follow-up issue has been filed"). Generated loops are told to file every promised follow-up issue before writing the body, cite it by number (filed as #N), and rungh issue view <N>on every#Nthe body mentions, not only the ones after a closing keyword.Dans-Plugins/Medieval-FactionsPR #2019) was a dispatch interrupted between writing the body and filing the issue.RESEARCH.md§7 Implementations entry is added.Closes #133
Retrofit note: this adds a rule to the template, so every existing
<slug>-dev-loopskill generated before this change lacks it. That includescreate-dev-loop-dev-loop(template-version44756ec) andmedieval-factions-dev-loop, where the gap was first observed (its #49). Each probably needs a retrofit pass. Only the operator can see the full list of installed skills.Skipped issues: all other open issues were deferred to keep this PR to one change. #173 (remaining half) and #106 need
CLAUDE.mdedits, which require separate authorization. #109 and #114 are human-gated verification questions. The remainingtemplate-ruleissues and #141/#143 are independent template changes left for later cycles.Research grounding
RESEARCH.md §7 (LLM triage is a filter, not a decision-maker): its implication is that skip reasoning must be auditable rather than silent. PR #29 added "Record skip reasons", but a skip reason that points at a not-yet-filed issue can't be audited. This change ties the promise to an artifact that already exists. It is also related to §4 (re-state scope at boundaries), the basis of the existing
Closes #Ncheck (PR #26).Doc sync check
README.md's "What it does" Step list still matchescreate-dev-loop.md's Steps 1:1 (no Step changed){{placeholder}}added or changedRESEARCH.mdupdated (an Implementations entry under §7)Test plan
python3 scripts/check_docs.pyprinted "Doc consistency check passed."python3 -m unittest discover -s testsran 42 tests, OK/create-dev-loopwas not run against a real repo. This headless dispatch isn't authorized to create a GitHub repo (Step 6) or write to~/local-skills//~/.claude/commands/, so none of the fiveCLAUDE.md"Testing changes" items were exercised (see [self-audit] The repo's own validation anchor is structurally unrunnable in a headless dispatch, so template changes can never merge autonomously #109). The change is one added prose paragraph with no placeholder, socheck_docs.pycovers the main mechanical risk. Its behavior in a generated skill has not been checked.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson