Repository navigation
Say where a hand-set server-id counts, and when a count goes untagged - #46
Merged
dmccoystephenson merged 2 commits intoNov 12, 2026
Merged
Conversation
The README's "Resetting it" paragraph did not say that only a column-0 server-id: line outside the tags: block is read, nor that a quoted value is accepted, so an operator who indented the line would see a new ID appended. "The wire format" said a coalesced count always carries the coalesced tag, which withCount skips at 32 tags. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (scored against the diff, CI run 43143677395 and the source):
One finding, fixed in ecae0e6: README.md:85 read "a Anchor: This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
dmccoystephenson
deleted the
feature/readme-server-id-and-count-tag-drift
branch
November 12, 2026 02:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage A — documentation accuracy sweep. Two README claims were found to drift from
TraceClient.java; both are corrected here, in sections that are not on the do-not-auto-merge list.Summary
server-id:line at column 0, outside thetags:block, is read (SERVER_ID_LINEis anchored at^, andparseServerWideConfigtreats indented lines in atags:block as tags), nor that a quoted value is accepted (scalar()unquotes it), nor that the first valid line wins. An operator who indented the line would have seen a fresh ID appended with no explanation. Each claim is already pinned inTraceClientTest("column 0 only", thetags:/server-id: xcase,server-id: "abc-123" # mine,first/second).coalesced.withCountskips the tag when the event already carriesMAX_TAGS(32) tags, as the "Repeated events are coalesced" section already says. The wire-format sentence now says the same.The full sweep also checked the example snippet, the "What
reportpromises" table, "Opting out", "Server-wide tags", "Getting it" (version0.7.0agrees withpom.xml, the header andVERSION), "Building" (matches thebuild.ymlmatrix 8/17/21), the class and method Javadoc, and thepom.xmldescription. No further drift was found.Test plan
mvn -B verify) validates no file in this diff (UNVERIFIED-not-applicable), and the CI matrix is still expected green on the head.parseServerWideConfig,scalar,withCountand the existing tests named above.Deferred issues
Every open issue (#13, #15, #27, #31, #39, #40, #42) was skipped this cycle: each needs a maintainer decision on the opt-out contract, the wire format, or the user-facing "Opting out" wording, all of which are human-gated.
No tracking issue — gap found during triage.
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson