Repository navigation
Pin how the server-id: line is matched, and a non-UTF-8 install ID file - #49
Merged
dmccoystephenson merged 1 commit intoNov 15, 2026
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (performed inline, anchored on CI run 43688279948):
Judgment notes:
Summary: a tests-only PR, CI green on all three legs, and nothing on the do-not-auto-merge list is touched. This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
dmccoystephenson
deleted the
feature/pin-server-id-line-and-non-utf8-install-id-file
branch
November 15, 2026 07:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage B unit-test expansion: two line-reader edges that no test exercised are now pinned. Only tests are added, and no production code is changed.
Summary
installId_theServerIdLineNeedsNoSpaceAroundItsColonAndIsCaseSensitive:SERVER_ID_LINE(^server-id\s*:(.*)$) takes its value straight after the colon (server-id:abc), allows whitespace before the colon and tabs around the value, and matches the name exactly (Server-Id:,server_id:andserver-ids:are not the line). This differs from atags:entry, wherea:bis treated as a string rather than a pair, so the difference is now recorded by a test rather than left implicit.installIdFile_aFileThatIsNotUtf8IsLeftAloneAndAnInMemoryIdIsUsed: an install ID file holding a valid ID line below an ISO-8859-1 comment fails to decode as UTF-8.build()does not throw, the client stays enabled with an in-memory UUID, the file is left byte for byte, andcould not read install ID fileis logged atFINE. The code comment inloadOrCreateInstallIdnames "not UTF-8" as one of the unreadable cases, and until now no test drove it. This is the same fail-to-decode behaviour that An enabled: false in a server-wide config that is not plain UTF-8 is ignored #40 describes for the server-wide file. Here it only costs a stable ID, not an opt-out, so no new issue is filed.Test plan
mvn -B verifylocally on Java 21:Tests run: 118, Failures: 0, Errors: 0, Skipped: 0, and both new tests appear in the surefire reportbuild (8),build (17),build (21)greenWork selection
Every open issue (#13, #15, #27, #31, #39, #40, #42) is deferred because each asks for a maintainer decision on the opt-out contract, the wire format, or the "Opting out" README wording, which is on the do-not-auto-merge list. A Stage A documentation sweep of
README.md, the class and method Javadoc,pom.xmlandbuild.ymlagainst the code found no drift, so this cycle falls back to test expansion.No tracking issue: these gaps were found during triage.
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson