Skip to content

fix(ydisk): drop the link to a compare page the site does not build - #683

Merged
leemour merged 1 commit into
mainfrom
fix/ydisk-compare-link
Nov 17, 2026
Merged

leemour merged 1 commit into
mainfrom
fix/ydisk-compare-link

Conversation

@leemour

@leemour leemour commented Nov 17, 2026

Copy link
Copy Markdown
Member

Task

The Deploy after #681 failed in pnpm check:links: en/ru/es/docs/ydisk.html and their llms.mdx copies link to /docs/ydisk/compare, which the built site does not have (6 failures, all this link). Every later deploy, including #682's, carries the same failure.

Why the page is not built

scripts/localize.ts builds site-owned pages (translations/pages/<tool>/compare.<lang>.md) through siteOwnedFor(tool) during pnpm sync, and sync runs only for tools in tools.json. Notion is in tools.json; ydisk is not: it is a hand-written page, content/docs/ydisk.mdx. So nothing reads translations/pages/ydisk/.

What

  • The compare sentence and its link are removed from content/docs/ydisk.mdx, ydisk.ru.mdx and ydisk.es.mdx.
  • translations/pages/ydisk/compare.*.md and the ydisk/compare SEO entries stay: the page publishes by itself once ydisk joins tools.json.

Not in this PR

Making ydisk a synced tool: a tools.json entry (package @wirecat/yandex-disk-cli, not found on npm today), RU/ES translations of its pages, and the overview moved to translations/overviews/. A decision for the owner.

Testing

  • pnpm check:links --source, pnpm docs:check pass.
  • A local pnpm build (needed for the full pnpm check:links) was killed for lack of memory, so the deploy's own link check is the full check.

🤖 Generated with Claude Code

The deploy failed in check:links: the ydisk overview links to
/docs/ydisk/compare in EN/RU/ES, but sync builds a tool's site-owned pages
(translations/pages/<tool>/compare.<lang>.md) only for tools in tools.json,
and ydisk is a hand-written page, not a synced tool. The compare sources
stay; the page publishes once ydisk joins tools.json.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@leemour
leemour merged commit 4c32bf7 into main Nov 17, 2026
2 checks passed
@leemour
leemour deleted the fix/ydisk-compare-link branch November 17, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant