Repository navigation
fix(ydisk): drop the link to a compare page the site does not build - #683
Merged
Merged
Conversation
The deploy failed in check:links: the ydisk overview links to /docs/ydisk/compare in EN/RU/ES, but sync builds a tool's site-owned pages (translations/pages/<tool>/compare.<lang>.md) only for tools in tools.json, and ydisk is a hand-written page, not a synced tool. The compare sources stay; the page publishes once ydisk joins tools.json. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
The Deploy after #681 failed in
pnpm check:links:en/ru/es/docs/ydisk.htmland theirllms.mdxcopies link to/docs/ydisk/compare, which the built site does not have (6 failures, all this link). Every later deploy, including #682's, carries the same failure.Why the page is not built
scripts/localize.tsbuilds site-owned pages (translations/pages/<tool>/compare.<lang>.md) throughsiteOwnedFor(tool)duringpnpm sync, and sync runs only for tools intools.json. Notion is intools.json; ydisk is not: it is a hand-written page,content/docs/ydisk.mdx. So nothing readstranslations/pages/ydisk/.What
content/docs/ydisk.mdx,ydisk.ru.mdxandydisk.es.mdx.translations/pages/ydisk/compare.*.mdand theydisk/compareSEO entries stay: the page publishes by itself once ydisk joinstools.json.Not in this PR
Making ydisk a synced tool: a
tools.jsonentry (package@wirecat/yandex-disk-cli, not found on npm today), RU/ES translations of its pages, and the overview moved totranslations/overviews/. A decision for the owner.Testing
pnpm check:links --source,pnpm docs:checkpass.pnpm build(needed for the fullpnpm check:links) was killed for lack of memory, so the deploy's own link check is the full check.🤖 Generated with Claude Code