Repository navigation
Conversation
Jugen
marked this pull request as ready for review
November 16, 2026 16:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: A
disjoint()ordisjointById()to-one prefetch over a binary (byte[]) FK doesn’t set the relationship on the source objects. readPropertyDirectly(...) returns null.Cause:
ResultScanParentAttachmentStrategyindexes parents in a HashMap keyed by raw join values, and byte[] uses identity equals/hashCode. Compound keys have the same problem, because List.equals compares the elements by identity.Fix: Wrap byte[] join values, including each element of a compound key, in ByteBuffer, which compares by content.
Tests: Two new tests in DataContextBinaryPKIT (disjoint and disjointById) that assert the attachment with queries blocked.
Related: the disjointById case with several keys also needs CAY-3079 (IN list binding).