Repository navigation
Conversation
Jugen
marked this pull request as ready for review
November 16, 2026 17:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: An IN qualifier with byte[] values on a binary column produces one ? per byte. This covers inDbExp(..), disjointById() to-one prefetches over several keys, and to-many disjointById() from several binary-key masters. The result is a SQL error, as on HSQLDB, or no matches.
Cause: In
ValueNode.appendValue, the array branch expands every byte[] into its bytes, including the elements of an Object[] IN list.Fix: When the node’s
DbAttributeis binary (TypesMapping.isBinary(): BINARY, VARBINARY, LONGVARBINARY, BLOB), a byte[] is bound as one value. Other byte[] values expand as before. Also,HierarchicalObjectResolvernow deduplicates disjointById IN values by content, so equal binary keys from different rows aren’t repeated.Tests: New ValueNodeTest (placeholders and bindings, plus the expansion that is kept) and DataContextBinaryPKInListIT.
Related: attaching the to-one prefetch result over binary keys is fixed separately in CAY-3078.