Repository navigation
Conversation
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The checksum subshell loop, Maven RAT rename, Java 17/11 baselines, TinkerPop 3.8.1 and Groovy 4.0.25 versions, and the HStore OLAP clear/remove, bounded-batch and no-writer-coordination text match pom.xml, computer/pom.xml, HstoreStore.deleteOlapData and the OLAP schema jobs on master. One time-anchored JDK comment, in both languages.
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Score: 9/10. Summary: The subshell checksum loop stops on the first failed or missing sidecar, the JDK 17/11, Maven RAT, TinkerPop 3.8.1 and Groovy 4.0.25 text matches the Server, Toolchain and Computer poms, and the HStore OLAP clear/remove, bounded-batch and no-writer-coordination rows match HstoreStore.deleteOlapData and the OLAP schema jobs; the earlier time-anchored Computer JDK comment is fixed in both languages.
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The checksum loop, gpg steps, JDK 17/11, TinkerPop 3.8.1, Groovy 4.0.25 and HStore OLAP clear/remove text match the code and poms; one inserted blockquote break splits a sentence into two paragraphs in both languages.
imbajin
left a comment
There was a problem hiding this comment.
Score: 8.5/10 · Confidence: medium
Blocking: no
Summary
No new issues found. The existing minor formatting issue splits the serializer explanation across paragraphs in both languages.
Evidence
Reviewed bilingual diff and HStore cleanup implementation; bounded batch commits and lack of writer coordination match the guidance. The earlier JDK wording was fixed.
Validation notes
No live release verification or distributed HStore integration test was run.
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Score: 9/10. Summary: The subshell checksum loop stops on the first failed or missing sidecar in bash and zsh, the JDK 17/11, Maven RAT, TinkerPop 3.8.1 and HStore OLAP clear/remove, bounded-batch and no-writer-coordination text match the Server and Computer poms, HstoreStore.deleteOlapData and the OLAP schema jobs on master, and both earlier wording comments are fixed in both languages.
imbajin
left a comment
There was a problem hiding this comment.
Score: 9.0/10 · Confidence: medium
Blocking: no
Summary
No new issues found in the bilingual release and migration guidance; both earlier wording findings are fixed.
Evidence
Reviewed the checksum loop, release baselines and HStore OLAP cleanup and schema jobs; bounded commits and the concurrent-writer warning match the implementation.
Validation notes
No live release validation or distributed HStore integration test was run.
…hing in release validation
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Score: 9/10. Summary: The sidecar grep filter matches every published 1.5.0, 1.7.0 and 1.8.0 RC .sha512 file, accepts the BSD SHA512 (file) = form and still stops on a bad hash, missing sidecar or wrong filename in bash and zsh, and the Check validator note matches validate-release.yml, where only dist/validate-release.sh writes GITHUB_STEP_SUMMARY.
imbajin
left a comment
There was a problem hiding this comment.
Score: 7.5/10 · Confidence: high
Blocking: yes
Summary
The manual checksum loop can report success without checking the intended archive when a sidecar names a similar file.
Evidence
A local shell reproduction with a corrupt package-1.8.0.tar.gz and a valid package-1X8X0.tar.gz checked the latter twice and exited successfully.
Validation notes
No live release validation or distributed HStore integration test was run; the false success requires a matching incorrect sidecar and a similarly named file.
| ( | ||
| for archive in *.tar.gz; do | ||
| printf '%s\n' "$archive" | ||
| grep -E "([[:space:]]|\*)${archive}$|^SHA512[[:space:]]*\(${archive}\)[[:space:]]*=" "$archive.sha512" | shasum -a 512 --check || exit "$?" |
There was a problem hiding this comment.
Compare the sidecar filename literally
$archive is interpolated into an extended regular expression, so the dots in a release filename match any character. For example, if the sidecar for package-1.8.0.tar.gz names an existing package-1X8X0.tar.gz, this filter accepts it and shasum checks the other file. I reproduced a successful loop with the intended archive corrupt and the other archive valid. Please compare the parsed filename literally for both supported checksum formats; the Chinese example needs the same fix.
Purpose of the PR
Repair release-verification examples that could execute prose as shell commands or hide an earlier checksum failure, and clarify the current migration workflow.
Validation: all Bash examples passed syntax checks. Checksum trials covered success, an early failure followed by a valid package, a missing sidecar and no archives. Source-contract review, strict artifact checks and independent cross-review passed. Public routes and legacy heading links are preserved.